From: Joe Perches <joe@perches.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Cc: clang-built-linux@googlegroups.com
Subject: Re: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough;
Date: Sat, 07 Mar 2020 23:02:23 -0800 [thread overview]
Message-ID: <259f405155a948f90229d3fc8cad928d434b46f9.camel@perches.com> (raw)
In-Reply-To: <6773b7e3-8ce4-55d1-8bb7-bde6d9f6e887@embeddedor.com>
On Sun, 2020-03-08 at 00:46 -0600, Gustavo A. R. Silva wrote:
>
> On 3/7/20 21:01, Joe Perches wrote:
> > On Sat, 2020-03-07 at 15:30 -0600, Gustavo A. R. Silva wrote:
> > > Some people consistently add blank lines as part of their code style,
> > > and if I were
> > > one of those people, I wouldn't like to have such lines removed.
> >
> > It's a patch generator, it's not perfect.
> > Nothing is nor ever will be.
>
> Wise words. The thing is that this is feedback over a proposed
> patch.
>
> > It's quite simple to add blank lines if that's
> > what any maintainer desires.
> >
>
> I'm not sure if you are saying that it's not a problem to
> update your proposed patch,
It's not a problem with my proposed patch.
Consistency is good.
Nearly all uses in mm do not have blank lines
after break.
> or if you are suggesting that
> the maintainers will have the predisposition of applying
> patches that will modify their coding style and then go and
> willingly fix that. I doubt the latter, though.
If any do actually use the script, I guess we'll see.
> --
> Gustavo
next prev parent reply other threads:[~2020-03-08 7:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 20:30 [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough; Joe Perches
2020-02-21 0:21 ` Andrew Morton
2020-02-21 2:24 ` Joe Perches
2020-03-09 19:36 ` Nick Desaulniers
2020-03-09 19:55 ` Joe Perches
2020-03-07 21:30 ` Gustavo A. R. Silva
2020-03-08 3:01 ` Joe Perches
2020-03-08 6:46 ` Gustavo A. R. Silva
2020-03-08 7:02 ` Joe Perches [this message]
2020-03-08 7:11 ` Gustavo A. R. Silva
2020-03-08 8:58 ` Joe Perches
2020-03-08 19:14 ` Gustavo A. R. Silva
2020-03-08 19:44 ` Joe Perches
2020-03-08 22:04 ` Gustavo A. R. Silva
2020-03-08 22:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=259f405155a948f90229d3fc8cad928d434b46f9.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).