linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
	linux-mmc@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	Harjani Ritesh <riteshh@codeaurora.org>,
	Jens Axboe <axboe@fb.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Mike Christie <mchristi@redhat.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: shawn.lin@rock-chips.com, LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/8] mmc/core/mmc_test: Add some spaces for better code readability
Date: Tue, 10 Jan 2017 16:35:32 +0800	[thread overview]
Message-ID: <259f881f-d9b1-c602-647c-ecb53b851e37@rock-chips.com> (raw)
In-Reply-To: <e9f51945-fe2a-c102-2f40-08635e4f6f69@users.sourceforge.net>

On 2017/1/9 5:46, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 8 Jan 2017 20:25:39 +0100
>
> Use space characters at some source code places according to
> the Linux coding style convention.
>

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/mmc/core/mmc_test.c | 42 +++++++++++++++++++++---------------------
>  1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 848f4f30e343..42aefd3df09b 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -641,11 +641,11 @@ static int __mmc_test_prepare(struct mmc_test_card *test, int write)
>  	if (write)
>  		memset(test->buffer, 0xDF, 512);
>  	else {
> -		for (i = 0;i < 512;i++)
> +		for (i = 0; i < 512; i++)
>  			test->buffer[i] = i;
>  	}
>
> -	for (i = 0;i < BUFFER_SIZE / 512;i++) {
> +	for (i = 0; i < BUFFER_SIZE / 512; i++) {
>  		ret = mmc_test_buffer_transfer(test, test->buffer, i, 512, 1);
>  		if (ret)
>  			return ret;
> @@ -674,7 +674,7 @@ static int mmc_test_cleanup(struct mmc_test_card *test)
>
>  	memset(test->buffer, 0, 512);
>
> -	for (i = 0;i < BUFFER_SIZE / 512;i++) {
> +	for (i = 0; i < BUFFER_SIZE / 512; i++) {
>  		ret = mmc_test_buffer_transfer(test, test->buffer, i, 512, 1);
>  		if (ret)
>  			return ret;
> @@ -946,7 +946,7 @@ static int mmc_test_transfer(struct mmc_test_card *test,
>  	unsigned long flags;
>
>  	if (write) {
> -		for (i = 0;i < blocks * blksz;i++)
> +		for (i = 0; i < blocks * blksz; i++)
>  			test->scratch[i] = i;
>  	} else {
>  		memset(test->scratch, 0, BUFFER_SIZE);
> @@ -980,7 +980,7 @@ static int mmc_test_transfer(struct mmc_test_card *test,
>
>  		memset(test->buffer, 0, sectors * 512);
>
> -		for (i = 0;i < sectors;i++) {
> +		for (i = 0; i < sectors; i++) {
>  			ret = mmc_test_buffer_transfer(test,
>  				test->buffer + i * 512,
>  				dev_addr + i, 512, 0);
> @@ -988,12 +988,12 @@ static int mmc_test_transfer(struct mmc_test_card *test,
>  				return ret;
>  		}
>
> -		for (i = 0;i < blocks * blksz;i++) {
> +		for (i = 0; i < blocks * blksz; i++) {
>  			if (test->buffer[i] != (u8)i)
>  				return RESULT_FAIL;
>  		}
>
> -		for (;i < sectors * 512;i++) {
> +		for (; i < sectors * 512; i++) {
>  			if (test->buffer[i] != 0xDF)
>  				return RESULT_FAIL;
>  		}
> @@ -1001,7 +1001,7 @@ static int mmc_test_transfer(struct mmc_test_card *test,
>  		local_irq_save(flags);
>  		sg_copy_to_buffer(sg, sg_len, test->scratch, BUFFER_SIZE);
>  		local_irq_restore(flags);
> -		for (i = 0;i < blocks * blksz;i++) {
> +		for (i = 0; i < blocks * blksz; i++) {
>  			if (test->scratch[i] != (u8)i)
>  				return RESULT_FAIL;
>  		}
> @@ -1086,7 +1086,7 @@ static int mmc_test_multi_write(struct mmc_test_card *test)
>
>  	sg_init_one(&sg, test->buffer, size);
>
> -	return mmc_test_transfer(test, &sg, 1, 0, size/512, 512, 1);
> +	return mmc_test_transfer(test, &sg, 1, 0, size / 512, 512, 1);
>  }
>
>  static int mmc_test_multi_read(struct mmc_test_card *test)
> @@ -1107,7 +1107,7 @@ static int mmc_test_multi_read(struct mmc_test_card *test)
>
>  	sg_init_one(&sg, test->buffer, size);
>
> -	return mmc_test_transfer(test, &sg, 1, 0, size/512, 512, 0);
> +	return mmc_test_transfer(test, &sg, 1, 0, size / 512, 512, 0);
>  }
>
>  static int mmc_test_pow2_write(struct mmc_test_card *test)
> @@ -1118,7 +1118,7 @@ static int mmc_test_pow2_write(struct mmc_test_card *test)
>  	if (!test->card->csd.write_partial)
>  		return RESULT_UNSUP_CARD;
>
> -	for (i = 1; i < 512;i <<= 1) {
> +	for (i = 1; i < 512; i <<= 1) {
>  		sg_init_one(&sg, test->buffer, i);
>  		ret = mmc_test_transfer(test, &sg, 1, 0, 1, i, 1);
>  		if (ret)
> @@ -1136,7 +1136,7 @@ static int mmc_test_pow2_read(struct mmc_test_card *test)
>  	if (!test->card->csd.read_partial)
>  		return RESULT_UNSUP_CARD;
>
> -	for (i = 1; i < 512;i <<= 1) {
> +	for (i = 1; i < 512; i <<= 1) {
>  		sg_init_one(&sg, test->buffer, i);
>  		ret = mmc_test_transfer(test, &sg, 1, 0, 1, i, 0);
>  		if (ret)
> @@ -1154,7 +1154,7 @@ static int mmc_test_weird_write(struct mmc_test_card *test)
>  	if (!test->card->csd.write_partial)
>  		return RESULT_UNSUP_CARD;
>
> -	for (i = 3; i < 512;i += 7) {
> +	for (i = 3; i < 512; i += 7) {
>  		sg_init_one(&sg, test->buffer, i);
>  		ret = mmc_test_transfer(test, &sg, 1, 0, 1, i, 1);
>  		if (ret)
> @@ -1172,7 +1172,7 @@ static int mmc_test_weird_read(struct mmc_test_card *test)
>  	if (!test->card->csd.read_partial)
>  		return RESULT_UNSUP_CARD;
>
> -	for (i = 3; i < 512;i += 7) {
> +	for (i = 3; i < 512; i += 7) {
>  		sg_init_one(&sg, test->buffer, i);
>  		ret = mmc_test_transfer(test, &sg, 1, 0, 1, i, 0);
>  		if (ret)
> @@ -1231,7 +1231,7 @@ static int mmc_test_align_multi_write(struct mmc_test_card *test)
>
>  	for (i = 1; i < TEST_ALIGN_END; i++) {
>  		sg_init_one(&sg, test->buffer + i, size);
> -		ret = mmc_test_transfer(test, &sg, 1, 0, size/512, 512, 1);
> +		ret = mmc_test_transfer(test, &sg, 1, 0, size / 512, 512, 1);
>  		if (ret)
>  			return ret;
>  	}
> @@ -1258,7 +1258,7 @@ static int mmc_test_align_multi_read(struct mmc_test_card *test)
>
>  	for (i = 1; i < TEST_ALIGN_END; i++) {
>  		sg_init_one(&sg, test->buffer + i, size);
> -		ret = mmc_test_transfer(test, &sg, 1, 0, size/512, 512, 0);
> +		ret = mmc_test_transfer(test, &sg, 1, 0, size / 512, 512, 0);
>  		if (ret)
>  			return ret;
>  	}
> @@ -1357,7 +1357,7 @@ static int mmc_test_multi_write_high(struct mmc_test_card *test)
>  	sg_init_table(&sg, 1);
>  	sg_set_page(&sg, test->highmem, size, 0);
>
> -	return mmc_test_transfer(test, &sg, 1, 0, size/512, 512, 1);
> +	return mmc_test_transfer(test, &sg, 1, 0, size / 512, 512, 1);
>  }
>
>  static int mmc_test_multi_read_high(struct mmc_test_card *test)
> @@ -1379,7 +1379,7 @@ static int mmc_test_multi_read_high(struct mmc_test_card *test)
>  	sg_init_table(&sg, 1);
>  	sg_set_page(&sg, test->highmem, size, 0);
>
> -	return mmc_test_transfer(test, &sg, 1, 0, size/512, 512, 0);
> +	return mmc_test_transfer(test, &sg, 1, 0, size / 512, 512, 0);
>  }
>
>  #else
> @@ -2147,7 +2147,7 @@ static int mmc_test_rw_multiple_sg_len(struct mmc_test_card *test,
>  	int i;
>
>  	for (i = 0 ; i < rw->len && ret == 0; i++) {
> -		ret = mmc_test_rw_multiple(test, rw, 512*1024, rw->size,
> +		ret = mmc_test_rw_multiple(test, rw, 512 * 1024, rw->size,
>  					   rw->sg_len[i]);
>  		if (ret)
>  			break;
> @@ -2954,7 +2954,7 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase)
>
>  	mmc_claim_host(test->card->host);
>
> -	for (i = 0;i < ARRAY_SIZE(mmc_test_cases);i++) {
> +	for (i = 0; i < ARRAY_SIZE(mmc_test_cases); i++) {
>  		struct mmc_test_general_result *gr;
>
>  		if (testcase && ((i + 1) != testcase))
> @@ -3165,7 +3165,7 @@ static int mtf_testlist_show(struct seq_file *sf, void *data)
>
>  	seq_puts(sf, "0:\tRun all tests\n");
>  	for (i = 0; i < ARRAY_SIZE(mmc_test_cases); i++)
> -		seq_printf(sf, "%d:\t%s\n", i+1, mmc_test_cases[i].name);
> +		seq_printf(sf, "%d:\t%s\n", i + 1, mmc_test_cases[i].name);
>
>  	mutex_unlock(&mmc_test_lock);
>
>


-- 
Best Regards
Shawn Lin

  parent reply	other threads:[~2017-01-10  8:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-08 21:38 [PATCH 0/8] MMC-core: Fine-tuning for some function implementations SF Markus Elfring
2017-01-08 21:42 ` [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init() SF Markus Elfring
2017-01-09 18:31   ` Linus Walleij
2017-01-10  7:37     ` Chunyan Zhang
2017-01-10  8:44   ` Shawn Lin
2017-01-11  1:59   ` Andy Shevchenko
2017-01-08 21:43 ` [PATCH 2/8] mmc-core: Fix a typo in a comment line SF Markus Elfring
2017-01-09 18:32   ` Linus Walleij
2017-01-10  8:43   ` Shawn Lin
2017-01-08 21:45 ` [PATCH 3/8] mmc-core: Use seq_puts() in mtf_testlist_show() SF Markus Elfring
2017-01-09 18:33   ` Linus Walleij
2017-01-10  8:41   ` Shawn Lin
2017-01-08 21:46 ` [PATCH 4/8] mmc/core/mmc_test: Add some spaces for better code readability SF Markus Elfring
2017-01-09 18:34   ` Linus Walleij
2017-01-10  8:35   ` Shawn Lin [this message]
2017-01-08 21:47 ` [PATCH 5/8] mmc/core/mmc_test: Combine substrings for 5 messages SF Markus Elfring
2017-01-09 18:35   ` Linus Walleij
2017-01-10  8:34   ` Shawn Lin
2017-01-08 21:49 ` [PATCH 6/8] mmc/core/mmc_test: Improve a size determination in five functions SF Markus Elfring
2017-01-09 18:35   ` Linus Walleij
2017-01-10  8:31   ` Shawn Lin
2017-01-08 21:50 ` [PATCH 7/8] mmc-core: Use kcalloc() in mmc_test_alloc_mem() SF Markus Elfring
2017-01-09 18:36   ` Linus Walleij
2017-01-10  8:28   ` Shawn Lin
2017-01-08 21:55 ` [PATCH 8/8] mmc-core: Use kmalloc_array() in mmc_alloc_sg() SF Markus Elfring
2017-01-09 18:37   ` Linus Walleij
2017-01-10  8:27   ` Shawn Lin
2017-01-12 12:01 ` [PATCH 0/8] MMC-core: Fine-tuning for some function implementations Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=259f881f-d9b1-c602-647c-ecb53b851e37@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=adrian.hunter@intel.com \
    --cc=axboe@fb.com \
    --cc=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mchristi@redhat.com \
    --cc=riteshh@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).