From: Sagi Grimberg <sagi@grimberg.me>
To: Alexander Gordeev <agordeev@redhat.com>, linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs()
Date: Thu, 6 Oct 2016 00:47:26 +0300 [thread overview]
Message-ID: <259f9d8c-e552-7565-5e05-88a1c8430317@grimberg.me> (raw)
In-Reply-To: <7459c980dd965b5f7b91e3bf1c3114d658535229.1475241231.git.agordeev@redhat.com>
> @@ -1908,33 +1909,36 @@ static void blk_mq_realloc_hw_ctxs(struct blk_mq_tag_set *set,
> if (node == NUMA_NO_NODE)
> node = set->numa_node;
>
> - hctxs[i] = kzalloc_node(sizeof(struct blk_mq_hw_ctx),
> - GFP_KERNEL, node);
> - if (!hctxs[i])
> + hctx = kzalloc_node(sizeof(*hctx), GFP_KERNEL, node);
> + if (!hctx)
> break;
>
> - if (blk_mq_init_hctx(q, set, hctxs[i], i, node)) {
> - kfree(hctxs[i]);
> - hctxs[i] = NULL;
> + if (blk_mq_init_hctx(q, set, hctx, i, node)) {
> + kfree(hctx);
> break;
> }
> - blk_mq_hctx_kobj_init(hctxs[i]);
> +
> + blk_mq_hctx_kobj_init(hctx);
> + hctxs[i] = hctx;
> }
> for (j = i; j < q->nr_hw_queues; j++) {
> - struct blk_mq_hw_ctx *hctx = hctxs[j];
> + hctx = hctxs[i];
Didn't you mean hctx[j]?
next prev parent reply other threads:[~2016-10-05 21:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 13:23 [PATCH v2 0/8] blk-mq: Minor cleanups Alexander Gordeev
2016-09-30 13:23 ` [PATCH v2 1/8] block: Get rid of unused request_queue::nr_queues member Alexander Gordeev
2016-10-05 21:37 ` Sagi Grimberg
2016-09-30 13:23 ` [PATCH v2 2/8] blk-mq: Remove a redundant assignment Alexander Gordeev
2016-10-05 21:37 ` Sagi Grimberg
2016-09-30 13:23 ` [PATCH v2 3/8] blk-mq: Fix hardware context data node selection Alexander Gordeev
2016-10-05 21:38 ` Sagi Grimberg
2016-09-30 13:23 ` [PATCH v2 4/8] blk-mq: Cleanup a loop exit condition Alexander Gordeev
2016-10-05 21:41 ` Sagi Grimberg
2016-09-30 13:23 ` [PATCH v2 5/8] blk-mq: Cleanup blk_mq_hw_ctx::cpumask (de-)allocation Alexander Gordeev
2016-10-05 21:43 ` Sagi Grimberg
2016-09-30 13:23 ` [PATCH v2 6/8] blk-mq: Rework blk_mq_realloc_hw_ctxs() Alexander Gordeev
2016-10-05 21:47 ` Sagi Grimberg [this message]
2016-10-06 8:25 ` Alexander Gordeev
2016-10-06 10:11 ` Sagi Grimberg
2016-10-09 21:30 ` [PATCH v3 " Alexander Gordeev
2016-09-30 13:23 ` [PATCH v2 7/8] blk-mq: Pair blk_mq_hctx_kobj_init() with blk_mq_hctx_kobj_put() Alexander Gordeev
2016-10-05 21:47 ` Sagi Grimberg
2016-10-09 21:31 ` [PATCH v3 " Alexander Gordeev
2016-09-30 13:23 ` [PATCH v2 8/8] blk-mq: Cleanup (de-)allocation of blk_mq_hw_ctx::ctxs Alexander Gordeev
2016-10-05 21:48 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=259f9d8c-e552-7565-5e05-88a1c8430317@grimberg.me \
--to=sagi@grimberg.me \
--cc=agordeev@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).