From: Johan Jonker <jbx6244@gmail.com>
To: Yifeng Zhao <yifeng.zhao@rock-chips.com>,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, heiko@sntech.de,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v15 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others
Date: Sun, 6 Dec 2020 15:10:57 +0100 [thread overview]
Message-ID: <259fe1ce-6bcb-3a26-493d-87bbd2eaff5e@gmail.com> (raw)
In-Reply-To: <0abf1dbd-13bb-cd92-907c-849f05ea887c@gmail.com>
Hi Yifeng,
Meanwhile, could you post a RFC version for Uboot based on this version
plus comments, so people can test the whole process from programming,
booting and kernel?
On 11/30/20 1:49 PM, Johan Jonker wrote:
> Hi,
>
> Looks good to me.
> Do the maintainers or someone else have any major issues?
> Could Miquel indicate if a version 16 must be send for that 'ret'
> variable alone or is it OK now?
>
>
> On 11/30/20 11:00 AM, Yifeng Zhao wrote:
>> This driver supports Rockchip NFC (NAND Flash Controller) found on RK3308,
>> RK2928, RKPX30, RV1108 and other SOCs. The driver has been tested using
>> 8-bit NAND interface on the ARM based RK3308 platform.
[..]
>> +/**
>> + * struct rk_ecc_cnt_status: represent a ecc status data.
represent the ECC status data.
>> + * @err_flag_bit: error flag bit index at register.
>> + * @low: ECC count low bit index at register.
>> + * @low_mask: mask bit.
>> + * @low_bn: ECC count low bit number.
>> + * @high: ECC count high bit index at register.
>> + * @high_mask: mask bit
>> + */
next prev parent reply other threads:[~2020-12-06 14:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 10:00 [PATCH v15 0/8] Add Rockchip NFC drivers for RK3308 and others Yifeng Zhao
2020-11-30 10:00 ` [PATCH v15 1/8] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Yifeng Zhao
2020-11-30 10:00 ` [PATCH v15 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Yifeng Zhao
2020-11-30 12:49 ` Johan Jonker
2020-12-06 14:10 ` Johan Jonker [this message]
2020-12-07 9:56 ` Miquel Raynal
2020-12-08 7:23 ` 赵仪峰
2020-11-30 10:00 ` [PATCH v15 3/8] MAINTAINERS: add maintainers to ROCKCHIP NFC Yifeng Zhao
2020-11-30 10:00 ` [PATCH v15 4/8] arm64: dts: rockchip: Add NFC node for RK3308 SoC Yifeng Zhao
2020-11-30 10:01 ` [PATCH v15 5/8] arm64: dts: rockchip: Add NFC node for PX30 SoC Yifeng Zhao
2020-11-30 10:01 ` [PATCH v15 6/8] arm: dts: rockchip: Add NFC node for RV1108 SoC Yifeng Zhao
2020-11-30 10:01 ` [PATCH v15 7/8] arm: dts: rockchip: Add NFC node for RK2928 and other SoCs Yifeng Zhao
2020-11-30 10:01 ` [PATCH v15 8/8] arm: dts: rockchip: Add NFC node for RK3036 SoC Yifeng Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=259fe1ce-6bcb-3a26-493d-87bbd2eaff5e@gmail.com \
--to=jbx6244@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).