From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754341AbcKHUWA (ORCPT ); Tue, 8 Nov 2016 15:22:00 -0500 Received: from mail-sn1nam02on0087.outbound.protection.outlook.com ([104.47.36.87]:11215 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754161AbcKHUV6 (ORCPT ); Tue, 8 Nov 2016 15:21:58 -0500 X-Greylist: delayed 3561 seconds by postgrey-1.27 at vger.kernel.org; Tue, 08 Nov 2016 15:21:57 EST From: "Madhani, Himanshu" To: Mauricio Faria de Oliveira , "qla2xxx-upstream@qlogic.com" CC: "jejb@linux.vnet.ibm.com" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O Thread-Topic: [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O Thread-Index: AQHSOTCqzGgvbwgjr0irYGLJaZWDmKDO1+sA Date: Tue, 8 Nov 2016 17:47:44 +0000 Message-ID: <25A8D59D-ED2B-4E97-80DD-36F347862DEC@cavium.com> References: <1478548411-17932-1-git-send-email-mauricfo@linux.vnet.ibm.com> In-Reply-To: <1478548411-17932-1-git-send-email-mauricfo@linux.vnet.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Himanshu.Madhani@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [173.186.134.106] x-ms-office365-filtering-correlation-id: 4cd88703-b8a1-45ee-2ffc-08d407ff58b1 x-microsoft-exchange-diagnostics: 1;SN1PR0701MB1840;7:xOAAuBIFUTy/iCogIuiJ/O969urtRtkP+SowosktzRLQm87SpWpk2GwYrR1EOTUaOjCtsoyvsJ97os+oZpuN5UiW9eFYSY17PvQsDedG0cA+y2az9xTTiyKOhLuGTv8CB/fpe47AWy7inaBIBfal9HiLtEwEu5e8w09k6vIB3BrMr/p52QUdS42XomFx26F3MDwXgiz4rzExmZO9inELro+ne/nLQdd9Dgb7zn9BRNpTR8kIWFaaS2ZNi5oJivt+CqQZhH5Nsc7dcG7idKY5bx71tY5YFV9l/noJxrccBqVFVwcdREFvRrzWbHiXuMUPejH7IFcTKrWz6XajP81nE/T+COWgbNUyaNKi0oOwJZA= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0701MB1840; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(104084551191319); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:SN1PR0701MB1840;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0701MB1840; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(189002)(51914003)(24454002)(199003)(377454003)(105586002)(99286002)(76176999)(586003)(81156014)(106356001)(101416001)(106116001)(5660300001)(81166006)(7736002)(7846002)(36756003)(102836003)(305945005)(33656002)(50986999)(6116002)(3846002)(54356999)(8676002)(2950100002)(87936001)(3280700002)(2900100001)(68736007)(5001770100001)(92566002)(66066001)(77096005)(4326007)(3660700001)(97736004)(189998001)(2501003)(8936002)(122556002)(2906002)(82746002)(83716003)(86362001)(104396002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0701MB1840;H:SN1PR0701MB1837.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <704158789F7B5D49AC0728EA426C4049@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2016 17:47:44.9101 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB1840 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uA8KM8wP010361 On 11/7/16, 11:53 AM, "Mauricio Faria de Oliveira" wrote: >This patchset addresses a couple of errors that might happen during >PCI device remove (e.g., PCI hotplug, PowerVM DLPAR), which prevent >the successful removal and re-addition of the adapter to the system, >and cause an oops and/or invalid DMA access (triggers an EEH event). > >It allowed several cycles of PCI device add/remove with ongoing I/O, >to complete successfully without triggering oopses or EEH events. > >Verified on v4.9-rc3. > >Test-case: >--- > # lspci > <...> > 001d:70:00.0 Fibre Channel: QLogic Corp. ISP2532-based ... > 001d:70:00.1 Fibre Channel: QLogic Corp. ISP2532-based ... > <...> > > # for sd in $(find /sys/bus/pci/devices/001d:70:00.*/ \ > -name 'sd*' -printf "%f\n"); do \ > dd if=/dev/$sd of=/dev/null iflag=nocache & done > > # echo 1 | tee /sys/bus/pci/devices/001d:70:00.*/remove > (this either works or not) > > # echo 1 > /sys/bus/pci/rescan > >Before: >--- > <...> > EEH: Frozen PHB#1d-PE#700000 detected > qla2xxx [001d:70:00.1]-8042:2: PCI/Register disconnect, exiting. > <...> > EEH: Detected PCI bus error on PHB#29-PE#700000 > <...> > (and/or) > Unable to handle kernel paging request for data at address 0x00000138 > <...> > NIP [d000000004700a40] qla2xxx_queuecommand+0x80/0x3f0 [qla2xxx] > LR [d000000004700a10] qla2xxx_queuecommand+0x50/0x3f0 [qla2xxx] > > (command does not return; adapter cannot be re-added) > >After: >--- > <...> > qla2xxx [001d:70:00.0]-801c:1: Abort command issued nexus=1:0:0 -- 1 2003. > <...> > qla2xxx [001d:70:00.1]-801c:2: Abort command issued nexus=2:3:0 -- 1 2003. > <...> > > (command does return; adapter can be re-added correctly) > > >Mauricio Faria de Oliveira (2): > qla2xxx: do not queue commands when unloading > qla2xxx: fix invalid DMA access after command aborts in PCI device > remove > > drivers/scsi/qla2xxx/qla_os.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > >-- >1.8.3.1 > Thanks for the patches. Series Looks Good. Acked-by: Himanshu Madhani >