From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756579AbdKDJau (ORCPT ); Sat, 4 Nov 2017 05:30:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:50963 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752221AbdKDJas (ORCPT ); Sat, 4 Nov 2017 05:30:48 -0400 Subject: Re: [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC To: Manivannan Sadhasivam Cc: mturquette@baylibre.com, sboyd@codeaurora.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, davem@davemloft.net, mchehab@kernel.org, rdunlap@infradead.org, daniel.thompson@linaro.org, amit.kucheria@linaro.org, liuwei@actions-semi.com References: <1509479663-8985-1-git-send-email-manivannan.sadhasivam@linaro.org> <1509479663-8985-3-git-send-email-manivannan.sadhasivam@linaro.org> <7c87aee4-dde4-ab3d-06b0-75f3686ab5dd@suse.de> <20171104091949.GB14705@linaro.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <25a2e233-f565-8baa-17e2-9c867bbbe9d0@suse.de> Date: Sat, 4 Nov 2017 17:30:36 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171104091949.GB14705@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 04.11.2017 um 17:19 schrieb Manivannan Sadhasivam: >>> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile >>> index c99f363..821c1e1 100644 >>> --- a/drivers/clk/Makefile >>> +++ b/drivers/clk/Makefile >>> @@ -75,6 +75,7 @@ endif >>> obj-y += mvebu/ >>> obj-$(CONFIG_ARCH_MXS) += mxs/ >>> obj-$(CONFIG_COMMON_CLK_NXP) += nxp/ >>> +obj-$(CONFIG_ARCH_ACTIONS) += owl/ >>> obj-$(CONFIG_MACH_PISTACHIO) += pistachio/ >>> obj-$(CONFIG_COMMON_CLK_PXA) += pxa/ >>> obj-$(CONFIG_COMMON_CLK_QCOM) += qcom/ >>> diff --git a/drivers/clk/owl/Makefile b/drivers/clk/owl/Makefile >>> new file mode 100644 >>> index 0000000..dbba0af >>> --- /dev/null >>> +++ b/drivers/clk/owl/Makefile >>> @@ -0,0 +1,2 @@ >>> +obj-y += clk.o clk-pll.o clk-factor.o >>> +obj-$(CONFIG_ARCH_ACTIONS) += clk-s900.o >> >> $(CONFIG_ARCH_ACTIONS) is superfluous here. >> > Okay. Since, we haven't added ARCH_ACTIONS to defconfig yet I intentionally > made this conditional compilation. > > Would like a suggestion from you on this! My point was that the ../Makefile already uses $(CONFIG_ARCH_ACTIONS), so $(CONFIG_ARCH_ACTIONS) can never be n here. Instead you should probably either use $(CONFIG_ARM64) or better some new Kconfig option (CONFIG_CLK_OWL_S900?), so that we don't unnecessarily compile S900 on 32-bit arm and S500 on arm64. Another point: What about S700? Does it need to duplicate clk-s900.c or can we share any code between the two? Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)