From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C10EC433EF for ; Sun, 3 Oct 2021 11:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C37161153 for ; Sun, 3 Oct 2021 11:35:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbhJCLhQ (ORCPT ); Sun, 3 Oct 2021 07:37:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbhJCLgv (ORCPT ); Sun, 3 Oct 2021 07:36:51 -0400 Received: from relay02.th.seeweb.it (relay02.th.seeweb.it [IPv6:2001:4b7a:2000:18::163]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09D59C0613EC for ; Sun, 3 Oct 2021 04:35:03 -0700 (PDT) Received: from [192.168.1.101] (83.6.167.124.neoplus.adsl.tpnet.pl [83.6.167.124]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 7BD371F67A; Sun, 3 Oct 2021 13:35:01 +0200 (CEST) Message-ID: <25a61a6c-a339-27c3-4bf0-35aad014c954@somainline.org> Date: Sun, 3 Oct 2021 13:35:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH 11/11] arm64: dts: qcom: sm7225: Add device tree for Fairphone 4 Content-Language: en-US To: Luca Weiss , linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, Andy Gross , Bjorn Andersson , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211003083141.613509-1-luca@z3ntu.xyz> <20211003083141.613509-12-luca@z3ntu.xyz> From: Konrad Dybcio In-Reply-To: <20211003083141.613509-12-luca@z3ntu.xyz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.10.2021 10:31, Luca Weiss wrote: > Add device tree for the Fairphone 4 smartphone which is based on > Snapdragon 750G (sm7225) which is basically sm6350. > > Currently supported are UART, physical buttons (power & volume), screen > (based on simple-framebuffer set up by the bootloader), regulators and > USB. > > Signed-off-by: Luca Weiss > --- > [...] > + > +&pm6350_gpios { > + gpio_keys_pins: gpio-keys-pins { 'pin' singular, I guess > + pinconf { > + pins = "gpio2"; > + function = PMIC_GPIO_FUNC_NORMAL; > + bias-pull-up; > + input-enable; > + power-source = <0>; > + }; pinconf {} is not necessary [...] Other than that: Reviewed-by: Konrad Dybcio Konrad