From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DF89C2D0EF for ; Tue, 31 Mar 2020 02:38:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E32520748 for ; Tue, 31 Mar 2020 02:38:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729596AbgCaCiL (ORCPT ); Mon, 30 Mar 2020 22:38:11 -0400 Received: from mga03.intel.com ([134.134.136.65]:45459 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727464AbgCaCiL (ORCPT ); Mon, 30 Mar 2020 22:38:11 -0400 IronPort-SDR: B6qTxOv3qxFBkrpatBPAt/d61dc8ii3q8sTfS5y1gTxvlgRMhv+p90sp/vnBBLy5elhuBzub38 vIe1hT1ViQIg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 19:38:10 -0700 IronPort-SDR: gQqONHGZrVgABLM0UYtvVtd3YvvksEvwewAYtAH1kil4MKCavjAw7fhxHM8buNuoKamN30QltV /PgpMt6HxWAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,326,1580803200"; d="scan'208";a="359364093" Received: from yanbingl-mobl2.ccr.corp.intel.com ([10.249.171.104]) by fmsmga001.fm.intel.com with ESMTP; 30 Mar 2020 19:38:05 -0700 Message-ID: <25a7feacbd75821385aa310f3dbd87f70ed3ead2.camel@intel.com> Subject: Re: [PATCH v2 3/3] thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs From: Zhang Rui To: Gayatri Kammela , linux-pm@vger.kernel.org Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, lenb@kernel.org, dvhart@infradead.org, alex.hung@canonical.com, daniel.lezcano@linaro.org, amit.kucheria@verdurent.com, mika.westerberg@intel.com, peterz@infradead.org, charles.d.prestopine@intel.com, "5 . 6+" , Andy Shevchenko , Srinivas Pandruvada , "Rafael J . Wysocki" Date: Tue, 31 Mar 2020 10:38:04 +0800 In-Reply-To: <24125c0777458384f5b4449cafb5115b9985e3bd.1585343507.git.gayatri.kammela@intel.com> References: <24125c0777458384f5b4449cafb5115b9985e3bd.1585343507.git.gayatri.kammela@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-03-27 at 14:28 -0700, Gayatri Kammela wrote: > Tiger Lake's new unique ACPI device IDs for Intel thermal driver are > not > valid because of missing 'C' in the IDs. Fix the IDs by updating > them. > > After the update, the new IDs should now look like > INT1040 --> INTC1040 > INT1043 --> INTC1043 > > Fixes: 9b1b5535dfc9 ("thermal: int340x_thermal: Add Tiger Lake ACPI > device IDs") > Cc: 5.6+ # 5.6+ > Cc: Andy Shevchenko > Cc: Srinivas Pandruvada > Cc: Rafael J. Wysocki > Suggested-by: Srinivas Pandruvada > Signed-off-by: Gayatri Kammela Acked-by: Zhang Rui thanks, rui > --- > drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +- > drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > index efae0c02d898..71a9877b85a5 100644 > --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > @@ -369,7 +369,7 @@ static int int3400_thermal_remove(struct > platform_device *pdev) > } > > static const struct acpi_device_id int3400_thermal_match[] = { > - {"INT1040", 0}, > + {"INTC1040", 0}, > {"INT3400", 0}, > {} > }; > diff --git a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c > b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c > index aeece1e136a5..3849d5869609 100644 > --- a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c > +++ b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c > @@ -282,7 +282,7 @@ static int int3403_remove(struct platform_device > *pdev) > } > > static const struct acpi_device_id int3403_device_ids[] = { > - {"INT1043", 0}, > + {"INTC1043", 0}, > {"INT3403", 0}, > {"", 0}, > };