* [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
2020-03-27 21:28 [PATCH v2 0/3] Fixes: update Tiger Lake ACPI device IDs Gayatri Kammela
@ 2020-03-27 21:28 ` Gayatri Kammela
2020-03-30 16:43 ` Rafael J. Wysocki
2020-03-27 21:28 ` [PATCH v2 2/3] platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID Gayatri Kammela
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Gayatri Kammela @ 2020-03-27 21:28 UTC (permalink / raw)
To: linux-pm
Cc: platform-driver-x86, linux-kernel, lenb, dvhart, alex.hung,
rui.zhang, daniel.lezcano, amit.kucheria, mika.westerberg,
peterz, charles.d.prestopine, Gayatri Kammela, 5 . 6+,
Andy Shevchenko, Srinivas Pandruvada, Rafael J . Wysocki
Tiger Lake's new unique ACPI device IDs for DPTF and fan drivers are not
valid as the IDs are missing 'C'. Fix the IDs by updating them.
After the update, the new IDs should now look like
INT1047 --> INTC1047
INT1040 --> INTC1040
INT1043 --> INTC1043
INT1044 --> INTC1044
Fixes: 55cfe6a5c582 ("ACPI: DPTF: Add Tiger Lake ACPI device IDs")
Fixes: c248dfe7e0ca ("ACPI: fan: Add Tiger Lake ACPI device ID")
Cc: 5.6+ <stable@vger.kernel.org> # 5.6+
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Suggested-by: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
---
drivers/acpi/device_pm.c | 2 +-
drivers/acpi/dptf/dptf_power.c | 2 +-
drivers/acpi/dptf/int340x_thermal.c | 8 ++++----
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c
index b64c62bfcea5..80dae3b3c36a 100644
--- a/drivers/acpi/device_pm.c
+++ b/drivers/acpi/device_pm.c
@@ -1321,7 +1321,7 @@ int acpi_dev_pm_attach(struct device *dev, bool power_on)
*/
static const struct acpi_device_id special_pm_ids[] = {
{"PNP0C0B", }, /* Generic ACPI fan */
- {"INT1044", }, /* Fan for Tiger Lake generation */
+ {"INTC1044", }, /* Fan for Tiger Lake generation */
{"INT3404", }, /* Fan */
{}
};
diff --git a/drivers/acpi/dptf/dptf_power.c b/drivers/acpi/dptf/dptf_power.c
index 387f27ef3368..e5fb34bfa52c 100644
--- a/drivers/acpi/dptf/dptf_power.c
+++ b/drivers/acpi/dptf/dptf_power.c
@@ -97,7 +97,7 @@ static int dptf_power_remove(struct platform_device *pdev)
}
static const struct acpi_device_id int3407_device_ids[] = {
- {"INT1047", 0},
+ {"INTC1047", 0},
{"INT3407", 0},
{"", 0},
};
diff --git a/drivers/acpi/dptf/int340x_thermal.c b/drivers/acpi/dptf/int340x_thermal.c
index 1ec7b6900662..29b5c77256dd 100644
--- a/drivers/acpi/dptf/int340x_thermal.c
+++ b/drivers/acpi/dptf/int340x_thermal.c
@@ -13,10 +13,10 @@
#define INT3401_DEVICE 0X01
static const struct acpi_device_id int340x_thermal_device_ids[] = {
- {"INT1040"},
- {"INT1043"},
- {"INT1044"},
- {"INT1047"},
+ {"INTC1040"},
+ {"INTC1043"},
+ {"INTC1044"},
+ {"INTC1047"},
{"INT3400"},
{"INT3401", INT3401_DEVICE},
{"INT3402"},
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
2020-03-27 21:28 ` [PATCH v2 1/3] ACPI: fix: Update " Gayatri Kammela
@ 2020-03-30 16:43 ` Rafael J. Wysocki
2020-03-30 17:24 ` Andy Shevchenko
0 siblings, 1 reply; 11+ messages in thread
From: Rafael J. Wysocki @ 2020-03-30 16:43 UTC (permalink / raw)
To: Gayatri Kammela, Andy Shevchenko, Zhang, Rui
Cc: Linux PM, Platform Driver, Linux Kernel Mailing List, Len Brown,
Darren Hart, Alex Hung, Daniel Lezcano, Amit Kucheria,
Mika Westerberg, Peter Zijlstra, Prestopine, Charles D, 5 . 6+,
Srinivas Pandruvada, Rafael J . Wysocki
On Fri, Mar 27, 2020 at 10:34 PM Gayatri Kammela
<gayatri.kammela@intel.com> wrote:
>
> Tiger Lake's new unique ACPI device IDs for DPTF and fan drivers are not
> valid as the IDs are missing 'C'. Fix the IDs by updating them.
>
> After the update, the new IDs should now look like
> INT1047 --> INTC1047
> INT1040 --> INTC1040
> INT1043 --> INTC1043
> INT1044 --> INTC1044
>
> Fixes: 55cfe6a5c582 ("ACPI: DPTF: Add Tiger Lake ACPI device IDs")
> Fixes: c248dfe7e0ca ("ACPI: fan: Add Tiger Lake ACPI device ID")
> Cc: 5.6+ <stable@vger.kernel.org> # 5.6+
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Suggested-by: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
> Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
> ---
> drivers/acpi/device_pm.c | 2 +-
> drivers/acpi/dptf/dptf_power.c | 2 +-
> drivers/acpi/dptf/int340x_thermal.c | 8 ++++----
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c
> index b64c62bfcea5..80dae3b3c36a 100644
> --- a/drivers/acpi/device_pm.c
> +++ b/drivers/acpi/device_pm.c
> @@ -1321,7 +1321,7 @@ int acpi_dev_pm_attach(struct device *dev, bool power_on)
> */
> static const struct acpi_device_id special_pm_ids[] = {
> {"PNP0C0B", }, /* Generic ACPI fan */
> - {"INT1044", }, /* Fan for Tiger Lake generation */
> + {"INTC1044", }, /* Fan for Tiger Lake generation */
> {"INT3404", }, /* Fan */
> {}
> };
> diff --git a/drivers/acpi/dptf/dptf_power.c b/drivers/acpi/dptf/dptf_power.c
> index 387f27ef3368..e5fb34bfa52c 100644
> --- a/drivers/acpi/dptf/dptf_power.c
> +++ b/drivers/acpi/dptf/dptf_power.c
> @@ -97,7 +97,7 @@ static int dptf_power_remove(struct platform_device *pdev)
> }
>
> static const struct acpi_device_id int3407_device_ids[] = {
> - {"INT1047", 0},
> + {"INTC1047", 0},
> {"INT3407", 0},
> {"", 0},
> };
> diff --git a/drivers/acpi/dptf/int340x_thermal.c b/drivers/acpi/dptf/int340x_thermal.c
> index 1ec7b6900662..29b5c77256dd 100644
> --- a/drivers/acpi/dptf/int340x_thermal.c
> +++ b/drivers/acpi/dptf/int340x_thermal.c
> @@ -13,10 +13,10 @@
>
> #define INT3401_DEVICE 0X01
> static const struct acpi_device_id int340x_thermal_device_ids[] = {
> - {"INT1040"},
> - {"INT1043"},
> - {"INT1044"},
> - {"INT1047"},
> + {"INTC1040"},
> + {"INTC1043"},
> + {"INTC1044"},
> + {"INTC1047"},
> {"INT3400"},
> {"INT3401", INT3401_DEVICE},
> {"INT3402"},
> --
I can take this along with the other two patches in the series if that
is fine by Andy and Rui.
Thanks!
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
2020-03-30 16:43 ` Rafael J. Wysocki
@ 2020-03-30 17:24 ` Andy Shevchenko
2020-03-30 23:22 ` Kammela, Gayatri
0 siblings, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2020-03-30 17:24 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Gayatri Kammela, Zhang, Rui, Linux PM, Platform Driver,
Linux Kernel Mailing List, Len Brown, Darren Hart, Alex Hung,
Daniel Lezcano, Amit Kucheria, Mika Westerberg, Peter Zijlstra,
Prestopine, Charles D, 5 . 6+,
Srinivas Pandruvada, Rafael J . Wysocki
On Mon, Mar 30, 2020 at 06:43:35PM +0200, Rafael J. Wysocki wrote:
> On Fri, Mar 27, 2020 at 10:34 PM Gayatri Kammela
> <gayatri.kammela@intel.com> wrote:
> > - {"INT1044"},
> > - {"INT1047"},
> > + {"INTC1040"},
> > + {"INTC1043"},
> > + {"INTC1044"},
> > + {"INTC1047"},
> > {"INT3400"},
> > {"INT3401", INT3401_DEVICE},
> > {"INT3402"},
> > --
>
> I can take this along with the other two patches in the series if that
> is fine by Andy and Rui.
One nit is to fix the ordering to be alphanumeric or close enough
(I admit in some cases it might require unneeded churn) to that.
Otherwise,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread* RE: [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
2020-03-30 17:24 ` Andy Shevchenko
@ 2020-03-30 23:22 ` Kammela, Gayatri
2020-03-31 6:19 ` Rafael J. Wysocki
0 siblings, 1 reply; 11+ messages in thread
From: Kammela, Gayatri @ 2020-03-30 23:22 UTC (permalink / raw)
To: Andy Shevchenko, Rafael J. Wysocki
Cc: Zhang, Rui, Linux PM, Platform Driver, Linux Kernel Mailing List,
Len Brown, Darren Hart, Alex Hung, Daniel Lezcano, Amit Kucheria,
Westerberg, Mika, Peter Zijlstra, Prestopine, Charles D, 5 . 6+,
Pandruvada, Srinivas, Wysocki, Rafael J
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Monday, March 30, 2020 10:25 AM
> To: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Kammela, Gayatri <gayatri.kammela@intel.com>; Zhang, Rui
> <rui.zhang@intel.com>; Linux PM <linux-pm@vger.kernel.org>; Platform
> Driver <platform-driver-x86@vger.kernel.org>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Len Brown <lenb@kernel.org>; Darren Hart
> <dvhart@infradead.org>; Alex Hung <alex.hung@canonical.com>; Daniel
> Lezcano <daniel.lezcano@linaro.org>; Amit Kucheria
> <amit.kucheria@verdurent.com>; Westerberg, Mika
> <mika.westerberg@intel.com>; Peter Zijlstra <peterz@infradead.org>;
> Prestopine, Charles D <charles.d.prestopine@intel.com>; 5 . 6+
> <stable@vger.kernel.org>; Pandruvada, Srinivas
> <srinivas.pandruvada@intel.com>; Wysocki, Rafael J
> <rafael.j.wysocki@intel.com>
> Subject: Re: [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
>
> On Mon, Mar 30, 2020 at 06:43:35PM +0200, Rafael J. Wysocki wrote:
> > On Fri, Mar 27, 2020 at 10:34 PM Gayatri Kammela
> > <gayatri.kammela@intel.com> wrote:
>
> > > - {"INT1044"},
> > > - {"INT1047"},
> > > + {"INTC1040"},
> > > + {"INTC1043"},
> > > + {"INTC1044"},
> > > + {"INTC1047"},
> > > {"INT3400"},
> > > {"INT3401", INT3401_DEVICE},
> > > {"INT3402"},
> > > --
> >
> > I can take this along with the other two patches in the series if that
> > is fine by Andy and Rui.
>
> One nit is to fix the ordering to be alphanumeric or close enough (I admit in
> some cases it might require unneeded churn) to that.
Thanks Andy and Rafael! Should I send v3 for this series with right ordering this time?
>
> Otherwise,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> --
> With Best Regards,
> Andy Shevchenko
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
2020-03-30 23:22 ` Kammela, Gayatri
@ 2020-03-31 6:19 ` Rafael J. Wysocki
2020-04-01 11:29 ` Rafael J. Wysocki
0 siblings, 1 reply; 11+ messages in thread
From: Rafael J. Wysocki @ 2020-03-31 6:19 UTC (permalink / raw)
To: Kammela, Gayatri
Cc: Andy Shevchenko, Rafael J. Wysocki, Zhang, Rui, Linux PM,
Platform Driver, Linux Kernel Mailing List, Len Brown,
Darren Hart, Alex Hung, Daniel Lezcano, Amit Kucheria,
Westerberg, Mika, Peter Zijlstra, Prestopine, Charles D, 5 . 6+,
Pandruvada, Srinivas, Wysocki, Rafael J
On Tue, Mar 31, 2020 at 1:22 AM Kammela, Gayatri
<gayatri.kammela@intel.com> wrote:
>
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Monday, March 30, 2020 10:25 AM
> > To: Rafael J. Wysocki <rafael@kernel.org>
> > Cc: Kammela, Gayatri <gayatri.kammela@intel.com>; Zhang, Rui
> > <rui.zhang@intel.com>; Linux PM <linux-pm@vger.kernel.org>; Platform
> > Driver <platform-driver-x86@vger.kernel.org>; Linux Kernel Mailing List
> > <linux-kernel@vger.kernel.org>; Len Brown <lenb@kernel.org>; Darren Hart
> > <dvhart@infradead.org>; Alex Hung <alex.hung@canonical.com>; Daniel
> > Lezcano <daniel.lezcano@linaro.org>; Amit Kucheria
> > <amit.kucheria@verdurent.com>; Westerberg, Mika
> > <mika.westerberg@intel.com>; Peter Zijlstra <peterz@infradead.org>;
> > Prestopine, Charles D <charles.d.prestopine@intel.com>; 5 . 6+
> > <stable@vger.kernel.org>; Pandruvada, Srinivas
> > <srinivas.pandruvada@intel.com>; Wysocki, Rafael J
> > <rafael.j.wysocki@intel.com>
> > Subject: Re: [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
> >
> > On Mon, Mar 30, 2020 at 06:43:35PM +0200, Rafael J. Wysocki wrote:
> > > On Fri, Mar 27, 2020 at 10:34 PM Gayatri Kammela
> > > <gayatri.kammela@intel.com> wrote:
> >
> > > > - {"INT1044"},
> > > > - {"INT1047"},
> > > > + {"INTC1040"},
> > > > + {"INTC1043"},
> > > > + {"INTC1044"},
> > > > + {"INTC1047"},
> > > > {"INT3400"},
> > > > {"INT3401", INT3401_DEVICE},
> > > > {"INT3402"},
> > > > --
> > >
> > > I can take this along with the other two patches in the series if that
> > > is fine by Andy and Rui.
> >
> > One nit is to fix the ordering to be alphanumeric or close enough (I admit in
> > some cases it might require unneeded churn) to that.
> Thanks Andy and Rafael! Should I send v3 for this series with right ordering this time?
No need, I can fix up the ordering just fine.
> > Otherwise,
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks!
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
2020-03-31 6:19 ` Rafael J. Wysocki
@ 2020-04-01 11:29 ` Rafael J. Wysocki
0 siblings, 0 replies; 11+ messages in thread
From: Rafael J. Wysocki @ 2020-04-01 11:29 UTC (permalink / raw)
To: Kammela, Gayatri
Cc: Andy Shevchenko, Rafael J. Wysocki, Zhang, Rui, Linux PM,
Platform Driver, Linux Kernel Mailing List, Len Brown,
Darren Hart, Alex Hung, Daniel Lezcano, Amit Kucheria,
Westerberg, Mika, Peter Zijlstra, Prestopine, Charles D, 5 . 6+,
Pandruvada, Srinivas, Wysocki, Rafael J
On Tue, Mar 31, 2020 at 8:19 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, Mar 31, 2020 at 1:22 AM Kammela, Gayatri
> <gayatri.kammela@intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Sent: Monday, March 30, 2020 10:25 AM
> > > To: Rafael J. Wysocki <rafael@kernel.org>
> > > Cc: Kammela, Gayatri <gayatri.kammela@intel.com>; Zhang, Rui
> > > <rui.zhang@intel.com>; Linux PM <linux-pm@vger.kernel.org>; Platform
> > > Driver <platform-driver-x86@vger.kernel.org>; Linux Kernel Mailing List
> > > <linux-kernel@vger.kernel.org>; Len Brown <lenb@kernel.org>; Darren Hart
> > > <dvhart@infradead.org>; Alex Hung <alex.hung@canonical.com>; Daniel
> > > Lezcano <daniel.lezcano@linaro.org>; Amit Kucheria
> > > <amit.kucheria@verdurent.com>; Westerberg, Mika
> > > <mika.westerberg@intel.com>; Peter Zijlstra <peterz@infradead.org>;
> > > Prestopine, Charles D <charles.d.prestopine@intel.com>; 5 . 6+
> > > <stable@vger.kernel.org>; Pandruvada, Srinivas
> > > <srinivas.pandruvada@intel.com>; Wysocki, Rafael J
> > > <rafael.j.wysocki@intel.com>
> > > Subject: Re: [PATCH v2 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
> > >
> > > On Mon, Mar 30, 2020 at 06:43:35PM +0200, Rafael J. Wysocki wrote:
> > > > On Fri, Mar 27, 2020 at 10:34 PM Gayatri Kammela
> > > > <gayatri.kammela@intel.com> wrote:
> > >
> > > > > - {"INT1044"},
> > > > > - {"INT1047"},
> > > > > + {"INTC1040"},
> > > > > + {"INTC1043"},
> > > > > + {"INTC1044"},
> > > > > + {"INTC1047"},
> > > > > {"INT3400"},
> > > > > {"INT3401", INT3401_DEVICE},
> > > > > {"INT3402"},
> > > > > --
> > > >
> > > > I can take this along with the other two patches in the series if that
> > > > is fine by Andy and Rui.
> > >
> > > One nit is to fix the ordering to be alphanumeric or close enough (I admit in
> > > some cases it might require unneeded churn) to that.
> > Thanks Andy and Rafael! Should I send v3 for this series with right ordering this time?
>
> No need, I can fix up the ordering just fine.
>
> > > Otherwise,
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Thanks!
Now applied as 5.7 material with the changes mentioned above.
Please check the bleeding-edge branch in my tree.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 2/3] platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
2020-03-27 21:28 [PATCH v2 0/3] Fixes: update Tiger Lake ACPI device IDs Gayatri Kammela
2020-03-27 21:28 ` [PATCH v2 1/3] ACPI: fix: Update " Gayatri Kammela
@ 2020-03-27 21:28 ` Gayatri Kammela
2020-03-27 21:28 ` [PATCH v2 3/3] thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs Gayatri Kammela
2020-03-28 20:43 ` [PATCH v2 0/3] Fixes: update " Andy Shevchenko
3 siblings, 0 replies; 11+ messages in thread
From: Gayatri Kammela @ 2020-03-27 21:28 UTC (permalink / raw)
To: linux-pm
Cc: platform-driver-x86, linux-kernel, lenb, dvhart, alex.hung,
rui.zhang, daniel.lezcano, amit.kucheria, mika.westerberg,
peterz, charles.d.prestopine, Gayatri Kammela, 5 . 6+,
Andy Shevchenko, Srinivas Pandruvada, Rafael J . Wysocki
Tiger Lake's new unique ACPI device IDs for intel-hid driver is not
valid because of missing 'C' in the ID. Fix the ID by updating it.
After the update, the new ID should now look like
INT1051 --> INTC1051
Fixes: bdd11b654035 ("platform/x86: intel-hid: Add Tiger Lake ACPI device ID")
Cc: 5.6+ <stable@vger.kernel.org> # 5.6+
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Suggested-by: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
---
drivers/platform/x86/intel-hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index 43d590250228..c0a4696803eb 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -19,7 +19,7 @@ MODULE_LICENSE("GPL");
MODULE_AUTHOR("Alex Hung");
static const struct acpi_device_id intel_hid_ids[] = {
- {"INT1051", 0},
+ {"INTC1051", 0},
{"INT33D5", 0},
{"", 0},
};
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 3/3] thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs
2020-03-27 21:28 [PATCH v2 0/3] Fixes: update Tiger Lake ACPI device IDs Gayatri Kammela
2020-03-27 21:28 ` [PATCH v2 1/3] ACPI: fix: Update " Gayatri Kammela
2020-03-27 21:28 ` [PATCH v2 2/3] platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID Gayatri Kammela
@ 2020-03-27 21:28 ` Gayatri Kammela
2020-03-31 2:38 ` Zhang Rui
2020-03-28 20:43 ` [PATCH v2 0/3] Fixes: update " Andy Shevchenko
3 siblings, 1 reply; 11+ messages in thread
From: Gayatri Kammela @ 2020-03-27 21:28 UTC (permalink / raw)
To: linux-pm
Cc: platform-driver-x86, linux-kernel, lenb, dvhart, alex.hung,
rui.zhang, daniel.lezcano, amit.kucheria, mika.westerberg,
peterz, charles.d.prestopine, Gayatri Kammela, 5 . 6+,
Andy Shevchenko, Srinivas Pandruvada, Rafael J . Wysocki
Tiger Lake's new unique ACPI device IDs for Intel thermal driver are not
valid because of missing 'C' in the IDs. Fix the IDs by updating them.
After the update, the new IDs should now look like
INT1040 --> INTC1040
INT1043 --> INTC1043
Fixes: 9b1b5535dfc9 ("thermal: int340x_thermal: Add Tiger Lake ACPI device IDs")
Cc: 5.6+ <stable@vger.kernel.org> # 5.6+
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Suggested-by: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
---
drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
index efae0c02d898..71a9877b85a5 100644
--- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
@@ -369,7 +369,7 @@ static int int3400_thermal_remove(struct platform_device *pdev)
}
static const struct acpi_device_id int3400_thermal_match[] = {
- {"INT1040", 0},
+ {"INTC1040", 0},
{"INT3400", 0},
{}
};
diff --git a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
index aeece1e136a5..3849d5869609 100644
--- a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
@@ -282,7 +282,7 @@ static int int3403_remove(struct platform_device *pdev)
}
static const struct acpi_device_id int3403_device_ids[] = {
- {"INT1043", 0},
+ {"INTC1043", 0},
{"INT3403", 0},
{"", 0},
};
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 3/3] thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs
2020-03-27 21:28 ` [PATCH v2 3/3] thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs Gayatri Kammela
@ 2020-03-31 2:38 ` Zhang Rui
0 siblings, 0 replies; 11+ messages in thread
From: Zhang Rui @ 2020-03-31 2:38 UTC (permalink / raw)
To: Gayatri Kammela, linux-pm
Cc: platform-driver-x86, linux-kernel, lenb, dvhart, alex.hung,
daniel.lezcano, amit.kucheria, mika.westerberg, peterz,
charles.d.prestopine, 5 . 6+,
Andy Shevchenko, Srinivas Pandruvada, Rafael J . Wysocki
On Fri, 2020-03-27 at 14:28 -0700, Gayatri Kammela wrote:
> Tiger Lake's new unique ACPI device IDs for Intel thermal driver are
> not
> valid because of missing 'C' in the IDs. Fix the IDs by updating
> them.
>
> After the update, the new IDs should now look like
> INT1040 --> INTC1040
> INT1043 --> INTC1043
>
> Fixes: 9b1b5535dfc9 ("thermal: int340x_thermal: Add Tiger Lake ACPI
> device IDs")
> Cc: 5.6+ <stable@vger.kernel.org> # 5.6+
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Suggested-by: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
> Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
thanks,
rui
> ---
> drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
> drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index efae0c02d898..71a9877b85a5 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -369,7 +369,7 @@ static int int3400_thermal_remove(struct
> platform_device *pdev)
> }
>
> static const struct acpi_device_id int3400_thermal_match[] = {
> - {"INT1040", 0},
> + {"INTC1040", 0},
> {"INT3400", 0},
> {}
> };
> diff --git a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> index aeece1e136a5..3849d5869609 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> @@ -282,7 +282,7 @@ static int int3403_remove(struct platform_device
> *pdev)
> }
>
> static const struct acpi_device_id int3403_device_ids[] = {
> - {"INT1043", 0},
> + {"INTC1043", 0},
> {"INT3403", 0},
> {"", 0},
> };
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/3] Fixes: update Tiger Lake ACPI device IDs
2020-03-27 21:28 [PATCH v2 0/3] Fixes: update Tiger Lake ACPI device IDs Gayatri Kammela
` (2 preceding siblings ...)
2020-03-27 21:28 ` [PATCH v2 3/3] thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs Gayatri Kammela
@ 2020-03-28 20:43 ` Andy Shevchenko
3 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2020-03-28 20:43 UTC (permalink / raw)
To: Gayatri Kammela
Cc: Linux PM, Platform Driver, Linux Kernel Mailing List, Len Brown,
Darren Hart, Alex Hung, Zhang, Rui, Daniel Lezcano,
Amit Kucheria, Mika Westerberg, Peter Zijlstra (Intel),
Prestopine, Charles D, Andy Shevchenko, Srinivas Pandruvada,
Rafael J . Wysocki
On Fri, Mar 27, 2020 at 11:34 PM Gayatri Kammela
<gayatri.kammela@intel.com> wrote:
>
> Hi,
>
> The hardware IDs for devices supported by Tiger Lake for various drivers
> such as DPTF, fan, Intel thermal and intel-hid are added with missing 'C'
> which makes them invalid. Hence fix these IDs by updating.
>
> For instance, the updated ID now looks like
> INT1047 --> INTC1047
>
> Patch 1: Update Tiger Lake ACPI device IDs for DPTF and fan drivers
> Patch 2: Update Tiger Lake ACPI device ID for intel-hid driver
> Patch 3: Update Tiger Lake ACPI device IDs for thermal driver
>
Please, keep the IDs sorted (INTC should go after INT, etc).
Also I will need an Ack for patch 1 (at least).
> Changes since v1:
> 1) Added fixes tag to each patch
>
> Gayatri Kammela (3):
> ACPI: fix: Update Tiger Lake ACPI device IDs
> platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID
> thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs
>
> drivers/acpi/device_pm.c | 2 +-
> drivers/acpi/dptf/dptf_power.c | 2 +-
> drivers/acpi/dptf/int340x_thermal.c | 8 ++++----
> drivers/platform/x86/intel-hid.c | 2 +-
> drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
> drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 2 +-
> 6 files changed, 9 insertions(+), 9 deletions(-)
>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 11+ messages in thread