From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB104C31E46 for ; Wed, 12 Jun 2019 06:59:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B705205ED for ; Wed, 12 Jun 2019 06:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407767AbfFLG7a (ORCPT ); Wed, 12 Jun 2019 02:59:30 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:39105 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407711AbfFLG7a (ORCPT ); Wed, 12 Jun 2019 02:59:30 -0400 Received: by mail-ed1-f65.google.com with SMTP id m10so24020859edv.6 for ; Tue, 11 Jun 2019 23:59:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c7dWfW/bJapXFOFfkyjFdL/++/dUWMlX3e9jufSOBgY=; b=SZBw3W3DGcPThY4d4Mj6lMa3BniolP5hUc7eoKC6KVO9FFu3/bwB6dum1G8ntoTBXX Aq/K8Eivtwoo15tZhhw8cyJ+LcuyemTvUEi1DJ5PUbn0QP83IRNSvv7IgnKr7GjSy0PY 0MPARprIRD2opFDrw1UW7NUzBRvuWo8r+yhKOz02QwZ4jyt0ok6wHyUZCHoOGm8Qk67P b3gRmE2vBVJJuw+/nWkwb0jH3x/ZqQebcJl7xWsyYGHPbTtveYry1n+1+qgexVc6Xwni /xV8jEHbN19phgo98pbIQpRpVpBd5NsYCGGlPKng0mh9jf9RU1TorEjqY6g8Jo7AXUe8 KLZw== X-Gm-Message-State: APjAAAXUTTx+GWHWiKtgNnWQdGRELzN/qEBmV7rKNx7Tadntmc+g+1bt Grp5xFTgK2Vt8Oizjfwuz0aC5w== X-Google-Smtp-Source: APXvYqz7EBJgnGY0h5pkCYQHXm0g2k8yDiOt9z4W0eIZwSyszH0plvKKlSIJHiOzuRf+sYnWydswHg== X-Received: by 2002:a50:b062:: with SMTP id i89mr85945690edd.85.1560322768260; Tue, 11 Jun 2019 23:59:28 -0700 (PDT) Received: from shalem.localdomain (84-106-84-65.cable.dynamic.v4.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id d12sm1826542edp.16.2019.06.11.23.59.27 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jun 2019 23:59:27 -0700 (PDT) Subject: Re: [PATCH] platform/x86: asus-wmi: Only Tell EC the OS will handle display hotkeys from asus_nb_wmi To: Andy Shevchenko Cc: Darren Hart , Andy Shevchenko , Corentin Chary , acpi4asus-user , Platform Driver , Linux Kernel Mailing List , =?UTF-8?Q?Jo=c3=a3o_Paulo_Rechi_Vita?= References: <20190521062837.3887-1-hdegoede@redhat.com> <0018e660-c1d4-2c42-837f-ceb13d575b86@redhat.com> <41f5c7ff-20a3-ba6a-7ee3-2d3956d8b5a8@redhat.com> From: Hans de Goede Message-ID: <25b66e42-b281-3645-f80c-d93aad2d9da1@redhat.com> Date: Wed, 12 Jun 2019 08:59:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11-06-19 21:15, Andy Shevchenko wrote: > On Wed, Jun 5, 2019 at 9:15 PM Hans de Goede wrote: >> >> Hi, >> >> On 28-05-19 15:37, Hans de Goede wrote: >>> Hi, >>> >>> On 24-05-19 18:43, Andy Shevchenko wrote: >>>> On Tue, May 21, 2019 at 9:28 AM Hans de Goede wrote: >>>>> >>>>> Commit 78f3ac76d9e5 ("platform/x86: asus-wmi: Tell the EC the OS will >>>>> handle the display off hotkey") causes the backlight to be permanently off >>>>> on various EeePC laptop models using the eeepc-wmi driver (Asus EeePC >>>>> 1015BX, Asus EeePC 1025C). >>>>> >>>>> The asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT, 2, NULL) call added >>>>> by that commit is made conditional in this commit and only enabled in >>>>> the quirk_entry structs in the asus-nb-wmi driver fixing the broken >>>>> display / backlight on various EeePC laptop models. >>>>> >>>> >>>> Hmm... doesn't apply. >>> >>> That is likely because your review-andy branch contain a whole-bunch >>> of asus-wmi patches. >>> >>> Since this is a patch fixing a regression this should go to the fixes >>> branch. As the other patches so far are only in your review-andy branch >>> it is probably best to merge this patch to for-next + fixes first and >>> then rebase the set you have in review-andy on top, so that this can go >>> to fixes without getting a merge conflict when the rest of the patches >>> show up... >> >> Ping? This is a 5.x regression fix, as such it would be really good to >> get this into 5.2 and then cherry-picked into 5.y.z. >> > > It doesn't apply to our fixes branch. Weird. I will resend the patch rebased on top of 5.2-rc4. Regards, Hans