From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht
Cc: martin.botka@somainline.org, marijn.suijten@somainline.org,
jamipkettunen@somainline.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: Add support for SONY Xperia XZ2 / XZ2C / XZ3 (Tama platform)
Date: Thu, 11 Nov 2021 18:55:42 +0100 [thread overview]
Message-ID: <25b855a7-aeb9-cbdb-b832-d6fab0914569@somainline.org> (raw)
In-Reply-To: <fe19d7e6-8d31-a157-65d0-da53095485ea@somainline.org>
Il 11/11/21 03:16, Konrad Dybcio ha scritto:
>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
>> new file mode 100644
>> index 000000000000..6b088675f4b9
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
>> @@ -0,0 +1,442 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2021, Konrad Dybcio <konrad.dybcio@somainline.org>
>> + */
>> +
>> +#include <dt-bindings/input/input.h>
>> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>> +#include "sdm845.dtsi"
>> +#include "pm8005.dtsi"
>> +#include "pm8998.dtsi"
>> +#include "pmi8998.dtsi"
>> +
>> +/ {
>> + qcom,msm-id = <321 0x20001>; /* SDM845 v2.1 */
>> + qcom,board-id = <8 0>;
>> +
>> + gpio-keys {
>
> Whooops! It seems that I totally forgot to add a compatible to gpio-keys.. Could that be fixed when applying if the patch is otherwise good? Should it not be the case, I'll surely fix that in the next revision..
Just send a v2 of it, please. Makes it easier on the maintainers.
Apart from that,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
prev parent reply other threads:[~2021-11-11 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 19:14 [PATCH] arm64: dts: qcom: Add support for SONY Xperia XZ2 / XZ2C / XZ3 (Tama platform) Konrad Dybcio
2021-11-06 19:18 ` Martin Botka
2021-11-11 2:16 ` Konrad Dybcio
2021-11-11 17:55 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25b855a7-aeb9-cbdb-b832-d6fab0914569@somainline.org \
--to=angelogioacchino.delregno@somainline.org \
--cc=agross@kernel.org \
--cc=anton@enomsg.org \
--cc=bjorn.andersson@linaro.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=keescook@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).