From: Andrew Price <anprice@redhat.com>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk, cluster-devel@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [Cluster-devel] [PATCH] gfs2: make gfs2_fs_parameters static
Date: Thu, 17 Oct 2019 12:41:34 +0100 [thread overview]
Message-ID: <25bb4857-950e-592a-b2ba-7730867742b3@redhat.com> (raw)
In-Reply-To: <20191017110225.30841-1-ben.dooks@codethink.co.uk>
On 17/10/2019 12:02, Ben Dooks (Codethink) wrote:
> The gfs2_fs_parameters is not used outside the unit
> it is declared in, so make it static.
>
> Fixes the following sparse warning:
>
> fs/gfs2/ops_fstype.c:1331:39: warning: symbol 'gfs2_fs_parameters' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Bob Peterson <rpeterso@redhat.com>
> Cc: Andreas Gruenbacher <agruenba@redhat.com>
> Cc: cluster-devel@redhat.com
> Cc: linux-kernel@vger.kernel.org
> ---
> fs/gfs2/ops_fstype.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> index 681b44682b0d..ebdef1c5f580 100644
> --- a/fs/gfs2/ops_fstype.c
> +++ b/fs/gfs2/ops_fstype.c
> @@ -1328,7 +1328,7 @@ static const struct fs_parameter_enum gfs2_param_enums[] = {
> {}
> };
>
> -const struct fs_parameter_description gfs2_fs_parameters = {
> +static const struct fs_parameter_description gfs2_fs_parameters = {
> .name = "gfs2",
> .specs = gfs2_param_specs,
> .enums = gfs2_param_enums,
>
Looks good to me.
Thanks,
Andy
next prev parent reply other threads:[~2019-10-17 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 11:02 [PATCH] gfs2: make gfs2_fs_parameters static Ben Dooks (Codethink)
2019-10-17 11:41 ` Andrew Price [this message]
2019-10-17 12:46 ` [Cluster-devel] " Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25bb4857-950e-592a-b2ba-7730867742b3@redhat.com \
--to=anprice@redhat.com \
--cc=ben.dooks@codethink.co.uk \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).