From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C798FC433EF for ; Fri, 8 Oct 2021 13:33:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A455F61042 for ; Fri, 8 Oct 2021 13:33:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242251AbhJHNfT (ORCPT ); Fri, 8 Oct 2021 09:35:19 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:28901 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230324AbhJHNfS (ORCPT ); Fri, 8 Oct 2021 09:35:18 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HQptb6nDpzbmq7; Fri, 8 Oct 2021 21:28:55 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Fri, 8 Oct 2021 21:33:20 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.8; Fri, 8 Oct 2021 21:33:19 +0800 Message-ID: <25c6cc97-f436-8966-9052-a1841f68e81a@huawei.com> Date: Fri, 8 Oct 2021 21:33:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH v4 0/3] arm64: support page mapping percpu first chunk allocator Content-Language: en-US From: Kefeng Wang To: , , , , , , , , , , CC: References: <20210910053354.26721-1-wangkefeng.wang@huawei.com> <5cd6631f-0bac-bd74-3369-1fa4a744687f@huawei.com> In-Reply-To: <5cd6631f-0bac-bd74-3369-1fa4a744687f@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggeme709-chm.china.huawei.com (10.1.199.105) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/9/28 15:48, Kefeng Wang wrote: > Hi Catalin and Andrew, kindly ping again, any comments, thanks. Looks no more comments, Catalin and Andrew, ping again, any one of you could merge this patchset, many thanks. > > On 2021/9/10 13:33, Kefeng Wang wrote: >> Percpu embedded first chunk allocator is the firstly option, but it >> could fails on ARM64, eg, >>    "percpu: max_distance=0x5fcfdc640000 too large for vmalloc space >> 0x781fefff0000" >>    "percpu: max_distance=0x600000540000 too large for vmalloc space >> 0x7dffb7ff0000" >>    "percpu: max_distance=0x5fff9adb0000 too large for vmalloc space >> 0x5dffb7ff0000" >> >> then we could meet "WARNING: CPU: 15 PID: 461 at vmalloc.c:3087 >> pcpu_get_vm_areas+0x488/0x838", >> even the system could not boot successfully. >> >> Let's implement page mapping percpu first chunk allocator as a fallback >> to the embedding allocator to increase the robustness of the system. >> >> Also fix a crash when both NEED_PER_CPU_PAGE_FIRST_CHUNK and >> KASAN_VMALLOC enabled. >> >> Tested on ARM64 qemu with cmdline "percpu_alloc=page" based on v5.14. >> >> V4: >> - add ACK/RB >> - address comments about patch1 from Catalin >> - add Greg and Andrew into list suggested by Catalin >> >> v3: >> - search for a range that fits instead of always picking the end from >>    vmalloc area suggested by Catalin. >> - use NUMA_NO_NODE to avoid "virt_to_phys used for non-linear address:" >>    issue in arm64 kasan_populate_early_vm_area_shadow(). >> - add Acked-by: Marco Elver to patch v3 >> >> V2: >> - fix build error when CONFIG_KASAN disabled, found by lkp@intel.com >> - drop wrong __weak comment from kasan_populate_early_vm_area_shadow(), >>    found by Marco Elver >> >> Kefeng Wang (3): >>    vmalloc: Choose a better start address in vm_area_register_early() >>    arm64: Support page mapping percpu first chunk allocator >>    kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_VMALLOC >> >>   arch/arm64/Kconfig         |  4 ++ >>   arch/arm64/mm/kasan_init.c | 16 ++++++++ >>   drivers/base/arch_numa.c   | 82 +++++++++++++++++++++++++++++++++----- >>   include/linux/kasan.h      |  6 +++ >>   mm/kasan/init.c            |  5 +++ >>   mm/vmalloc.c               | 19 ++++++--- >>   6 files changed, 116 insertions(+), 16 deletions(-) >>