From: Connor Kuehl <connor.kuehl@canonical.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
gregkh@linuxfoundation.org, straube.linux@gmail.com,
devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step
Date: Mon, 23 Sep 2019 13:49:21 -0700 [thread overview]
Message-ID: <25c92ca9-0025-503e-3468-0df5de8ec2c9@canonical.com> (raw)
In-Reply-To: <c2ce3fb0-6407-982a-a3f2-172cef17f2a6@lwfinger.net>
On 9/23/19 1:38 PM, Larry Finger wrote:
> On 9/23/19 2:48 PM, Connor Kuehl wrote:
>> The local variable 'bcmd_down' is always set to true almost immediately
>> before the do-while's condition is checked. As a result, !bcmd_down
>> evaluates to false which short circuits the logical AND operator meaning
>> that the second operand is never reached and is therefore dead code.
>>
>> Addresses-Coverity: ("Logically dead code")
>>
>> Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
>> ---
>> drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
>> b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
>> index 47352f210c0b..a4b317937b23 100644
>> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
>> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
>> @@ -48,7 +48,6 @@ static u8 _is_fw_read_cmd_down(struct adapter
>> *adapt, u8 msgbox_num)
>> static s32 FillH2CCmd_88E(struct adapter *adapt, u8 ElementID, u32
>> CmdLen, u8 *pCmdBuffer)
>> {
>> u8 bcmd_down = false;
>> - s32 retry_cnts = 100;
>> u8 h2c_box_num;
>> u32 msgbox_addr;
>> u32 msgbox_ex_addr;
>> @@ -103,7 +102,7 @@ static s32 FillH2CCmd_88E(struct adapter *adapt,
>> u8 ElementID, u32 CmdLen, u8 *p
>> adapt->HalData->LastHMEBoxNum =
>> (h2c_box_num+1) % RTL88E_MAX_H2C_BOX_NUMS;
>> - } while ((!bcmd_down) && (retry_cnts--));
>> + } while (!bcmd_down);
>> ret = _SUCCESS;
>
> This patch is correct; however, the do..while loop will always be
> executed once, thus you could remove the loop and the loop variable
> bcmd_down.
Ah, yes! That makes sense, good catch.
>
> @greg: If you would prefer a two-step process, then this one is OK.
I'll do whichever is preferred. I'm happy to NACK this and send a v2
with the dead code and loop removed or I can send a separate patch based
on this one to remove the loop.
Thank you,
Connor
>
> Larry
>
next prev parent reply other threads:[~2019-09-23 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 19:48 [PATCH] staging: rtl8188eu: remove dead code in do-while conditional step Connor Kuehl
2019-09-23 20:38 ` Larry Finger
2019-09-23 20:49 ` Connor Kuehl [this message]
2019-09-24 6:17 ` Dan Carpenter
2019-09-24 6:15 ` Dan Carpenter
2019-09-24 14:25 ` NACK: " Connor Kuehl
2019-09-24 15:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25c92ca9-0025-503e-3468-0df5de8ec2c9@canonical.com \
--to=connor.kuehl@canonical.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).