From: Stephen Warren <swarren@wwwdotorg.org>
To: Mark Rutland <mark.rutland@arm.com>, robh+dt@kernel.org
Cc: Jisheng Zhang <jszhang@marvell.com>,
swarren@nvidia.com, sebastian.hesselbarth@gmail.com,
catalin.marinas@arm.com, will.deacon@arm.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc node
Date: Tue, 6 Sep 2016 10:04:36 -0600 [thread overview]
Message-ID: <25d8bfb3-0dbc-8c8d-019c-381d0a1d2994@wwwdotorg.org> (raw)
In-Reply-To: <20160906105758.GD1425@leverpostej>
On 09/06/2016 04:57 AM, Mark Rutland wrote:
> On Tue, Sep 06, 2016 at 06:20:48PM +0800, Jisheng Zhang wrote:
>> Hi Mark,
>>
>> On Tue, 6 Sep 2016 11:22:08 +0100 Mark Rutland wrote:
>>
>>> On Tue, Sep 06, 2016 at 04:55:55PM +0800, Jisheng Zhang wrote:
>>>> This patch fixes the following DTC warning with W=1:
>>>>
>>>> "Node /soc has a reg or ranges property, but no unit name"
>>>>
>>>> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
>>>
>>> The node is only compatible with simple-bus, and so shouldn't have a
>>> reg.
>>
>> IIUC, the warning is caused by "ranges = <0 0 0xf7000000 0x1000000>;"
>
> Hmm.. I've rather confused by that warning. Per ePAPR and the
> devicetree.org spec, the unit-addresss is meant to match the reg
> property, and no mention is made of the ranges property. So I do not
> think that it is necessary to require this.
>
> That warning seems to have gone into DTC in commit c9d9121683b35281
> ("Warn on node name unit-address presence/absence mismatch").
>
> Rob, Stephen, was there some discussion that prompted ranges requiring
> a matching unit-address?
It looks like there was some in response to V2 of the patch which
introduced this warning in dtc:
https://lkml.org/lkml/2013/9/19/301
I assume that's why Rob added that part to the patch when he reposted it.
next prev parent reply other threads:[~2016-09-06 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 8:55 [PATCH 0/3] arm64: dts: berlin: fix dtc warnings Jisheng Zhang
2016-09-06 8:55 ` [PATCH 1/3] arm64: dts: berlin4ct: add missing unit name to /soc node Jisheng Zhang
2016-09-06 10:22 ` Mark Rutland
2016-09-06 10:20 ` Jisheng Zhang
2016-09-06 10:57 ` Mark Rutland
2016-09-06 16:04 ` Stephen Warren [this message]
2016-09-06 8:55 ` [PATCH 2/3] arm64: dts: berlin4ct-stb: add missing unit name to /memory node Jisheng Zhang
2016-09-06 8:55 ` [PATCH 3/3] arm64: dts: berlin4ct-dmp: " Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25d8bfb3-0dbc-8c8d-019c-381d0a1d2994@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=swarren@nvidia.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).