From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933858AbeDXOMj (ORCPT ); Tue, 24 Apr 2018 10:12:39 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:27065 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933391AbeDXOMh (ORCPT ); Tue, 24 Apr 2018 10:12:37 -0400 Subject: Re: [PATCH v3 01/19] powerpc/powermac: Mark variable x as unused To: Mathieu Malaterre , Michael Ellerman Cc: Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20180328192717.656-1-malat@debian.org> <20180404200746.27379-1-malat@debian.org> From: Christophe LEROY Message-ID: <25e2ab60-2f1a-b491-3b3f-824cdaf1bfe3@c-s.fr> Date: Tue, 24 Apr 2018 16:12:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180404200746.27379-1-malat@debian.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 04/04/2018 à 22:07, Mathieu Malaterre a écrit : > Since the value of x is never intended to be read, declare it with gcc > attribute as unused. Fix warning treated as error with W=1: > > arch/powerpc/platforms/powermac/bootx_init.c:471:21: error: variable ‘x’ set but not used [-Werror=unused-but-set-variable] > > Suggested-by: Christophe Leroy > Signed-off-by: Mathieu Malaterre > --- > v3: style: add missing empty line after declaration > v2: move x variable within its local scope > > arch/powerpc/platforms/powermac/bootx_init.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powermac/bootx_init.c b/arch/powerpc/platforms/powermac/bootx_init.c > index c3c9bbb3573a..ba0964c17620 100644 > --- a/arch/powerpc/platforms/powermac/bootx_init.c > +++ b/arch/powerpc/platforms/powermac/bootx_init.c > @@ -468,7 +468,7 @@ void __init bootx_init(unsigned long r3, unsigned long r4) > boot_infos_t *bi = (boot_infos_t *) r4; > unsigned long hdr; > unsigned long space; > - unsigned long ptr, x; > + unsigned long ptr; > char *model; > unsigned long offset = reloc_offset(); > > @@ -562,6 +562,8 @@ void __init bootx_init(unsigned long r3, unsigned long r4) > * MMU switched OFF, so this should not be useful anymore. > */ > if (bi->version < 4) { > + unsigned long x __maybe_unused; > + That's detail, but shouldn't it be marked __always_unused instead ? Christophe > bootx_printf("Touching pages...\n"); > > /* >