From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754137AbdA0HIX (ORCPT ); Fri, 27 Jan 2017 02:08:23 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39685 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753970AbdA0HIV (ORCPT ); Fri, 27 Jan 2017 02:08:21 -0500 Subject: Re: [PATCH 3/3] powerpc: enable support for GCC plugins To: pageexec@freemail.hu, Kees Cook References: <20161206062800.21800-1-andrew.donnellan@au1.ibm.com> <584A8E9E.22035.590FC72@pageexec.freemail.hu> Cc: "linuxppc-dev@lists.ozlabs.org" , "kernel-hardening@lists.openwall.com" , Emese Revfy , LKML , linux-kbuild , Brad Spengler , Michal Marek From: Andrew Donnellan Date: Fri, 27 Jan 2017 16:52:54 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <584A8E9E.22035.590FC72@pageexec.freemail.hu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17012705-0008-0000-0000-0000010480FC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17012705-0009-0000-0000-000008F53918 Message-Id: <25e3a510-1652-5be9-cc26-24d35f9ac95e@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-27_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701270061 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/16 21:59, PaX Team wrote: >>>> the specific problem addressed here can (and IMHO should) be solved in >>>> another way: remove the inclusion of the offending headers in gcc-common.h >>>> as neither tm.h nor c-common.h are needed by existing plugins. for background, >> >> We can't build without tm.h: http://pastebin.com/W0azfCr0 > > you'll need to repeat the removal of dependent headers. based on a quick > test here across gcc 4.5-6.2, if you remove rtl.h, tm_p.h, hard-reg-set.h > and emit-rtl.h in addition to tm.h, the plugins should build fine. OK, I finally have a chance to look at this series again. basic-block.h includes tm.h, and I don't believe we can remove that. I'm not convinced there's a way around this. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited