From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99B7EC433E2 for ; Thu, 25 Mar 2021 09:30:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F20361A27 for ; Thu, 25 Mar 2021 09:30:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbhCYJ3g (ORCPT ); Thu, 25 Mar 2021 05:29:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230044AbhCYJ3I (ORCPT ); Thu, 25 Mar 2021 05:29:08 -0400 Received: from smtp-190f.mail.infomaniak.ch (smtp-190f.mail.infomaniak.ch [IPv6:2001:1600:3:17::190f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C905C06175F; Thu, 25 Mar 2021 02:29:03 -0700 (PDT) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4F5ftj1bChzMqSFq; Thu, 25 Mar 2021 10:29:01 +0100 (CET) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4F5ftZ3sl9zlh8TD; Thu, 25 Mar 2021 10:28:54 +0100 (CET) Subject: Re: [PATCH v30 02/12] landlock: Add ruleset and domain management To: James Morris Cc: Kees Cook , Jann Horn , "Serge E . Hallyn" , Al Viro , Andrew Morton , Andy Lutomirski , Anton Ivanov , Arnd Bergmann , Casey Schaufler , David Howells , Jeff Dike , Jonathan Corbet , Michael Kerrisk , Richard Weinberger , Shuah Khan , Vincent Dagonneau , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org, =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= References: <20210316204252.427806-1-mic@digikod.net> <20210316204252.427806-3-mic@digikod.net> <202103191114.C87C5E2B69@keescook> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <25f701bf-fddf-8e9c-1ac1-c50a38579096@digikod.net> Date: Thu, 25 Mar 2021 10:29:35 +0100 User-Agent: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/2021 21:31, James Morris wrote: > On Fri, 19 Mar 2021, Mickaël Salaün wrote: > >> >>>> Cc: Kees Cook >>>> Signed-off-by: Mickaël Salaün >>>> Acked-by: Serge Hallyn >>>> Link: https://lore.kernel.org/r/20210316204252.427806-3-mic@digikod.net >>> >>> (Aside: you appear to be self-adding your Link: tags -- AIUI, this is >>> normally done by whoever pulls your series. I've only seen Link: tags >>> added when needing to refer to something else not included in the >>> series.) >> >> It is an insurance to not lose history. :) > > How will history be lost? The code is in the repo and discussions can > easily be found by searching for subjects or message IDs. The (full and ordered) history may be hard to find without any Message-ID in commit messages. The Lore links keep that information (in the commit message) and redirect to the related archived email thread, which is very handy. For instance, Linus can rely on those links to judge the quality of a patch: https://lore.kernel.org/lkml/CAHk-=wh7xY3UF7zEc0BNVNjOox59jYBW-Gfi7=emm+BXPWc6nQ@mail.gmail.com/ > > Is anyone else doing this self linking? > I don't know, but it doesn't hurt. This way, if you're using git am without b4 am -l (or forgot to add links manually), the history is still pointed out by these self-reference links. I find it convenient and it is a safeguard to not forget them, no matter who takes the patches.