From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC35C4332F for ; Thu, 9 Dec 2021 13:08:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237587AbhLINMA (ORCPT ); Thu, 9 Dec 2021 08:12:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:37089 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233843AbhLINL7 (ORCPT ); Thu, 9 Dec 2021 08:11:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639055305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=igePiCAnnM/E+OTV8/OUnmXoD7Rv+G1QhGP97ZRcaHw=; b=XnGcYHg/p+VB6Z21PcHHkm+qS66kyd4hIOium+GJtM2toTqYeiLhyvUusonm4zMo+L7Ifh RUGu3KWGQiQ3Oax3/uWL1+qxDUxbyugjdz7kmxK0LUXRv512xoT+Kr+E4kTyg9oJMhZtD+ IwftvVfjIUx+HN2JbMXmTlWU5uxPCQ0= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-201-1ObY-7omMUicR_QCOOjQSA-1; Thu, 09 Dec 2021 08:08:23 -0500 X-MC-Unique: 1ObY-7omMUicR_QCOOjQSA-1 Received: by mail-oi1-f199.google.com with SMTP id bi9-20020a056808188900b002bc4f64083aso3860824oib.7 for ; Thu, 09 Dec 2021 05:08:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=igePiCAnnM/E+OTV8/OUnmXoD7Rv+G1QhGP97ZRcaHw=; b=xE8IWdLCbqXN1mIDwcNosNqZr5zqjErUsNwF4SQWOPC0Pfwt8dG33K1ikxXORF6PES JJ6wgI0wa/k/02p2JUssYjPpCNvLfg1l3t/w2Dg6qoek5CtkzaMLWFtcXKNS9FgtvL4/ RiyxYV+M5yfqJaS5V45B8BMWFJF/y2S8sg6CrH23npHE+Au1rKwn1cXoePJkMW1MaA8x it9kJ9TrPNwxBIbgTavZ09QqsUu4BC7SvWEq1RZQPO1cKliwiEzLGpLtKqIjfYx8I8Qj UjfB5CiUCXhvfTVuczx7px1Ei4/FadbJuLAaadIHyo3FB9T6anidM97a9OIi6WwKQa+n P1Pg== X-Gm-Message-State: AOAM533hqVTpDeGIzNEJqfmmxX58qNqA8CCk59pSbSVCnvTDoAqdNbU4 8HRgr+o0jwUTYIj8YylKgdp7Lf0NbwYOCpGmYZO6KROfWVZ6vo0nRd9KtvVjdpeAKJMAWqeKabW zW0cN8HbTcjHD+wyDl32Re5qe X-Received: by 2002:a05:6830:25c2:: with SMTP id d2mr4992194otu.51.1639055302564; Thu, 09 Dec 2021 05:08:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxOj8FG/2Pi1yxHBQAtiwFCtadHfrnS7LQSpnfphMhrmZpTQZwxCg7xbh8KQssGLtGweF1EXw== X-Received: by 2002:a05:6830:25c2:: with SMTP id d2mr4992158otu.51.1639055302337; Thu, 09 Dec 2021 05:08:22 -0800 (PST) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id n6sm1016113otj.78.2021.12.09.05.08.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Dec 2021 05:08:22 -0800 (PST) Subject: Re: [PATCH] drivers:ocrdma:remove unneeded variable To: cgel.zte@gmail.com, selvin.xavier@broadcom.com Cc: dledford@redhat.com, jgg@ziepe.ca, leon@kernel.org, dennis.dalessandro@cornelisnetworks.com, galpress@amazon.com, chi.minghao@zte.com.cn, mbloch@nvidia.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Zeal Robot References: <20211209015206.409528-1-chi.minghao@zte.com.cn> From: Tom Rix Message-ID: <260ff018-bf5b-07da-6988-c65c04f5bcb5@redhat.com> Date: Thu, 9 Dec 2021 05:08:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20211209015206.409528-1-chi.minghao@zte.com.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/8/21 5:52 PM, cgel.zte@gmail.com wrote: > From: chiminghao > > return value form directly instead of form > taking this in another redundant variable. Clean this message up. Maybe just 'Return status directly from function called.' Change itself looks fine. Reviewed-by: Tom Rix > > Reported-by: Zeal Robot > Signed-off-by: chiminghao > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index 735123d0e9ec..3bfbf4ec040d 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -1844,12 +1844,10 @@ int ocrdma_modify_srq(struct ib_srq *ibsrq, > > int ocrdma_query_srq(struct ib_srq *ibsrq, struct ib_srq_attr *srq_attr) > { > - int status; > struct ocrdma_srq *srq; > > srq = get_ocrdma_srq(ibsrq); > - status = ocrdma_mbx_query_srq(srq, srq_attr); > - return status; > + return ocrdma_mbx_query_srq(srq, srq_attr); > } > > int ocrdma_destroy_srq(struct ib_srq *ibsrq, struct ib_udata *udata) > @@ -1960,7 +1958,6 @@ static int ocrdma_build_inline_sges(struct ocrdma_qp *qp, > static int ocrdma_build_send(struct ocrdma_qp *qp, struct ocrdma_hdr_wqe *hdr, > const struct ib_send_wr *wr) > { > - int status; > struct ocrdma_sge *sge; > u32 wqe_size = sizeof(*hdr); > > @@ -1972,8 +1969,7 @@ static int ocrdma_build_send(struct ocrdma_qp *qp, struct ocrdma_hdr_wqe *hdr, > sge = (struct ocrdma_sge *)(hdr + 1); > } > > - status = ocrdma_build_inline_sges(qp, hdr, sge, wr, wqe_size); > - return status; > + return ocrdma_build_inline_sges(qp, hdr, sge, wr, wqe_size); > } > > static int ocrdma_build_write(struct ocrdma_qp *qp, struct ocrdma_hdr_wqe *hdr,