From: Richard Weinberger <richard@nod.at>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: tj@kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
ebiederm@xmission.com, dan j williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] [RFC] kernfs: Allow vm_ops->close() if VMA is never split
Date: Mon, 13 Jul 2020 09:42:51 +0200 (CEST) [thread overview]
Message-ID: <26112734.125046.1594626171647.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20200704205619.11172-1-richard@nod.at>
----- Ursprüngliche Mail -----
> Von: "richard" <richard@nod.at>
> An: "linux-kernel" <linux-kernel@vger.kernel.org>
> CC: tj@kernel.org, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, ebiederm@xmission.com, "dan j williams"
> <dan.j.williams@intel.com>, "richard" <richard@nod.at>
> Gesendet: Samstag, 4. Juli 2020 22:56:19
> Betreff: [PATCH] [RFC] kernfs: Allow vm_ops->close() if VMA is never split
> 10 years ago commit a6849fa1f7d7 ("sysfs: Fail bin file mmap if vma close is
> implemented.")
> removed support for vm_ops->close() for mmap on sysfs.
> As far I understand the reason is that due to the wrapping in kernfs
> every VMA split operation needs to be tracked to call vm_ops->close()
> for all fragments. This is not feasible with reasonable effort.
>
> Since commit 31383c6865a5 ("mm, hugetlbfs: introduce ->split() to
> vm_operations_struct")
> we can get notified as soon a VMA is split, this can help to relax the
> restriction.
> So I propose to allow having a custom close under the condition that a
> VMA cannot get split.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
*friendly ping*
Thanks,
//richard
next prev parent reply other threads:[~2020-07-13 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 20:56 [PATCH] [RFC] kernfs: Allow vm_ops->close() if VMA is never split Richard Weinberger
2020-07-13 7:42 ` Richard Weinberger [this message]
2020-07-13 12:35 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26112734.125046.1594626171647.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=dan.j.williams@intel.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).