From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755096AbdDRQwC (ORCPT ); Tue, 18 Apr 2017 12:52:02 -0400 Received: from mout.web.de ([212.227.15.4]:62533 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbdDRQwA (ORCPT ); Tue, 18 Apr 2017 12:52:00 -0400 Subject: [PATCH 2/6] ACPI-fan: Delete error messages for a failed memory allocation in two functions From: SF Markus Elfring To: linux-acpi@vger.kernel.org, Borislav Petkov , Chun-Yi Lee , Colin Ian King , Dan Williams , Len Brown , Linda Knippers , "Rafael J. Wysocki" , Tony Luck , Vishal Verma , Zhang Rui Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: <077115e4-8ec3-9c6d-0374-8ffc5e0f85c0@users.sourceforge.net> Message-ID: <261224e0-8a1a-fc1e-eb1c-9b6ac96a9cab@users.sourceforge.net> Date: Tue, 18 Apr 2017 18:51:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <077115e4-8ec3-9c6d-0374-8ffc5e0f85c0@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:goZztk2dfIiEh0wWiK8uWHSYwAKX109m29TdXDeECUojRmRZ3Iv Uf1XMfewNp8PBRPJIi/Q1j5jyOr9tp2bfXqlCGQ/zbBD5mPvzKBiKzgAfWlSnXQJdMC0MPz CsBxdbgwn0ahBWMPJiYpBeJoCUSztRY5CwVZROVhXtdcBHzXAevzyQ1oPT+GdfMjBGkj/Sl tgnlYsnc+YnP4p6fK/2pQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:7Td9iSSKPgc=:N3hOPYSgjBmkDCpw82nMQF IrEMpj0vsvuNDB+gJZ+SQkkOY5pcaOUonYj3fYxmw6/20jF52niX2s5MMSeXQldj0ZK/ppSPr k4FAGQ9hezoygjiYMFohb+ILQxwW6YJNn4agLr9nq09MDGZNGt1VIL6rrFfkXYTOYCR9uMuOF 8jVwD/uW2i9CaHHMkyEdggKk7IkCXRmlCUrnr1qwolr0n5L/KLYh7NGKC8r5Vwli2dDcggMh6 JnrKgdKNQhF/KP2rpF4N/jKE7aoOq/P0iuMMAEqS87sfkTwV5Ivijyunqf8bLTeSmA3mQmCUG hqk6KU2YLYA0YHTTjxxqSZcKjT/Flwgp25AfF8HPkMes/+CUOjg+rSPJbF91AQdpQLG50Umo0 pdOdHI54lNjtWl3TrE+3cyL0qT4JcdCBtdCpLGhfWN4HKjyZhOBS/c8Hi4sscaaeK0g6PJYk3 at0wg1YjlNSlkBC+6qX3cO+NQbwkr8pyy2OmASCVmA8RaOJyL4LGNjXelkXFmYiFVkueu4FKZ uwrjIklgts6flrUE/H1g5b9BoNitXnZ78g7EvygOEzq5f7wlykDWPBezVPYBC2cxVTYwUGrPr +24i1joaQZJICwpTJKlJ6Nw9hjW3huIuxGLxBdtjc79YxXNGy8jUKOdqAgphsB6PJuybhgDAU qrqsdsM5GsunrliHqtuxguomwufZ/ItjATsUn5Telo6WcBMYQmvio1xFZ83+kg8dyFpWyk924 jtfyh+/kkRaktSWvl10CwSPPa29HGG2FCJGTHXovKYbQ4iMcOlemB7M0bjbBc55Dnmg6WA+XH g9zF6Bx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 18 Apr 2017 17:10:40 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such statements here. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/acpi/fan.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c index 92878c7c523b..daa8f28a4b0e 100644 --- a/drivers/acpi/fan.c +++ b/drivers/acpi/fan.c @@ -301,7 +301,6 @@ static int acpi_fan_get_fps(struct acpi_device *device) fan->fps = devm_kcalloc(&device->dev, fan->fps_count, sizeof(*fan->fps), GFP_KERNEL); if (!fan->fps) { - dev_err(&device->dev, "Not enough memory\n"); status = -ENOMEM; goto err; } @@ -334,10 +333,9 @@ static int acpi_fan_probe(struct platform_device *pdev) char *name; fan = devm_kzalloc(&pdev->dev, sizeof(*fan), GFP_KERNEL); - if (!fan) { - dev_err(&device->dev, "No memory for fan\n"); + if (!fan) return -ENOMEM; - } + device->driver_data = fan; platform_set_drvdata(pdev, fan); -- 2.12.2