From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Clark Williams <williams@redhat.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH 3/4] perf map: Set kmap->kmaps backpointer for main kernel map chunks
Date: Thu, 6 Feb 2020 15:10:38 +0530 [thread overview]
Message-ID: <2617ead1-60e2-3da6-cde6-9efd68412139@linux.ibm.com> (raw)
In-Reply-To: <20191223133241.8578-4-acme@kernel.org>
Hi Arnaldo,
On 12/23/19 7:02 PM, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> When a map is create to represent the main kernel area (vmlinux) with
> map__new2() we allocate an extra area to store a pointer to the 'struct
> maps' for the kernel maps, so that we can access that struct when
> loading ELF files or kallsyms, as we will need to split it in multiple
> maps, one per kernel module or ELF section (such as ".init.text").
>
> So when map->dso->kernel is non-zero, it is expected that
> map__kmap(map)->kmaps to be set to the tree of kernel maps (modules,
> chunks of the main kernel, bpf progs put in place via
> PERF_RECORD_KSYMBOL, the main kernel).
>
> This was not the case when we were splitting the main kernel into chunks
> for its ELF sections, which ended up making 'perf report --children'
> processing a perf.data file with callchains to trip on
> __map__is_kernel(), when we press ENTER to see the popup menu for main
> histogram entries that starts at a symbol in the ".init.text" ELF
> section, e.g.:
>
> - 8.83% 0.00% swapper [kernel.vmlinux].init.text [k] start_kernel
> start_kernel
> cpu_startup_entry
> do_idle
> cpuidle_enter
> cpuidle_enter_state
> intel_idle
>
> Fix it.
perf top from perf/core has started crashing at __map__is_kernel():
(gdb) bt
#0 __map__is_kernel (map=<optimized out>) at util/map.c:935
#1 0x000000000045551d in perf_event__process_sample (machine=0xbab8f8,
sample=0x7fffe5ffa6d0, evsel=0xba7570, event=0xbcac50, tool=0x7fffffff84e0)
at builtin-top.c:833
#2 deliver_event (qe=<optimized out>, qevent=<optimized out>) at builtin-top.c:1192
#3 0x000000000050b9fb in do_flush (show_progress=false, oe=0x7fffffff87e0)
at util/ordered-events.c:244
#4 __ordered_events__flush (oe=oe@entry=0x7fffffff87e0, how=how@entry=OE_FLUSH__TOP,
timestamp=timestamp@entry=0) at util/ordered-events.c:323
#5 0x000000000050c1b5 in __ordered_events__flush (timestamp=<optimized out>,
how=<optimized out>, oe=<optimized out>) at util/ordered-events.c:339
#6 ordered_events__flush (how=OE_FLUSH__TOP, oe=0x7fffffff87e0) at util/ordered-events.c:341
#7 ordered_events__flush (oe=oe@entry=0x7fffffff87e0, how=how@entry=OE_FLUSH__TOP)
at util/ordered-events.c:339
#8 0x0000000000454e21 in process_thread (arg=0x7fffffff84e0) at builtin-top.c:1104
#9 0x00007ffff7f2c4e2 in start_thread () from /lib64/libpthread.so.0
#10 0x00007ffff76086d3 in clone () from /lib64/libc.so.6
I haven't debugged it much but seems like the actual patch that's causing the
crash is de90d513b246 ("perf map: Use map->dso->kernel + map__kmaps() in
map__kmaps()").
Did you face this / aware of it?
Ravi
next prev parent reply other threads:[~2020-02-06 9:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 13:32 [GIT PULL] perf/urgent improvements and fixes Arnaldo Carvalho de Melo
2019-12-23 13:32 ` [PATCH 1/4] tools lib traceevent: Fix memory leakage in filter_event Arnaldo Carvalho de Melo
2019-12-23 13:32 ` [PATCH 2/4] perf report: Fix incorrectly added dimensions as switch perf data file Arnaldo Carvalho de Melo
2019-12-23 13:32 ` [PATCH 3/4] perf map: Set kmap->kmaps backpointer for main kernel map chunks Arnaldo Carvalho de Melo
2020-02-06 9:40 ` Ravi Bangoria [this message]
2020-02-09 15:01 ` Jiri Olsa
2020-02-09 19:32 ` Jiri Olsa
2020-02-10 0:37 ` Jiri Olsa
2020-02-10 11:16 ` Ravi Bangoria
2020-02-10 13:13 ` Arnaldo Carvalho de Melo
2019-12-23 13:32 ` [PATCH 4/4] perf hists: Fix variable name's inconsistency in hists__for_each() macro Arnaldo Carvalho de Melo
2019-12-23 21:28 ` [GIT PULL] perf/urgent improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2617ead1-60e2-3da6-cde6-9efd68412139@linux.ibm.com \
--to=ravi.bangoria@linux.ibm.com \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).