From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mingyuan.ma@mediatek.com,
yf.wang@mediatek.com, libo.kang@mediatek.com,
chengci.xu@mediatek.com, youlin.pei@mediatek.com,
anan.sun@mediatek.com, xueqi.zhang@mediatek.com,
Guenter Roeck <groeck@chromium.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 3/4] iommu/mediatek: Validate number of phandles associated with "mediatek,larbs"
Date: Wed, 11 May 2022 16:53:41 +0200 [thread overview]
Message-ID: <26273bf5-c4a4-da9d-d722-da3880a27ce4@collabora.com> (raw)
In-Reply-To: <20220511064920.18455-4-yong.wu@mediatek.com>
Il 11/05/22 08:49, Yong Wu ha scritto:
> From: Guenter Roeck <groeck@chromium.org>
>
> Fix the smatch warnings:
> drivers/iommu/mtk_iommu.c:878 mtk_iommu_mm_dts_parse() error: uninitialized
> symbol 'larbnode'.
>
> If someone abuse the dtsi node(Don't follow the definition of dt-binding),
> for example "mediatek,larbs" is provided as boolean property, the code may
> crash. To fix this problem and improve the code safety, add some checking
> for the invalid input from dtsi, e.g. checking the larb_nr/larbid valid
> range, and avoid "mediatek,larb-id" property conflicts in the smi-larb
> nodes.
>
> Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Guenter Roeck <groeck@chromium.org>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2022-05-11 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 6:49 [PATCH 0/4] iommu/mediatek: Improve safety from dts Yong Wu
2022-05-11 6:49 ` [PATCH 1/4] iommu/mediatek: Use dev_err_probe to mute probe_defer err log Yong Wu
2022-05-11 8:42 ` Dan Carpenter
2022-05-11 14:53 ` AngeloGioacchino Del Regno
2022-05-11 15:24 ` Guenter Roeck
2022-05-11 6:49 ` [PATCH 2/4] iommu/mediatek: Add error path for loop of mm_dts_parse Yong Wu
2022-05-11 6:49 ` [PATCH 3/4] iommu/mediatek: Validate number of phandles associated with "mediatek,larbs" Yong Wu
2022-05-11 14:53 ` AngeloGioacchino Del Regno [this message]
2022-05-11 6:49 ` [PATCH 4/4] iommu/mediatek: Improve safety for mediatek,smi property in larb nodes Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26273bf5-c4a4-da9d-d722-da3880a27ce4@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=anan.sun@mediatek.com \
--cc=chengci.xu@mediatek.com \
--cc=dan.carpenter@oracle.com \
--cc=groeck@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=libo.kang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mingyuan.ma@mediatek.com \
--cc=will@kernel.org \
--cc=xueqi.zhang@mediatek.com \
--cc=yf.wang@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).