From: Stefan Berger <stefanb@linux.ibm.com>
To: Jarkko Sakkinen <jarkko@kernel.org>,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
linux-kernel@vger.kernel.org, Hulk Robot <hulkci@huawei.com>,
Wang Hai <wanghai38@huawei.com>
Subject: Re: [PATCH v2] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()
Date: Fri, 29 Jan 2021 13:57:58 -0500 [thread overview]
Message-ID: <262c3095-d4c0-f124-c8bc-e99685cbe572@linux.ibm.com> (raw)
In-Reply-To: <YBRHfZeqAirQolIN@kernel.org>
On 1/29/21 12:35 PM, Jarkko Sakkinen wrote:
> On Mon, Jan 25, 2021 at 08:47:53PM -0500, Stefan Berger wrote:
>> From: Stefan Berger <stefanb@linux.ibm.com>
>>
>> Return error code -ETIMEDOUT rather than '0' when waiting for the
>> rtce_buf to be set has timed out.
>>
>> Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Wang Hai <wanghai38@huawei.com>
>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
>> ---
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> Thanks! Should I add
>
> Cc: stable@vger.kernel.org to this?
Yes, that would be good! Thank you!
Stefan
>
> /Jarkko
>
>
>> drivers/char/tpm/tpm_ibmvtpm.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
>> index 994385bf37c0..813eb2cac0ce 100644
>> --- a/drivers/char/tpm/tpm_ibmvtpm.c
>> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
>> @@ -687,6 +687,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
>> ibmvtpm->rtce_buf != NULL,
>> HZ)) {
>> dev_err(dev, "CRQ response timed out\n");
>> + rc = -ETIMEDOUT;
>> goto init_irq_cleanup;
>> }
>>
>> --
>> 2.25.4
>>
>>
next prev parent reply other threads:[~2021-01-29 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 1:47 [PATCH v2] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe() Stefan Berger
2021-01-29 17:35 ` Jarkko Sakkinen
2021-01-29 18:57 ` Stefan Berger [this message]
2021-01-30 21:14 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262c3095-d4c0-f124-c8bc-e99685cbe572@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=hulkci@huawei.com \
--cc=jarkko@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=wanghai38@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).