From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Geliang Tang <geliangtang@gmail.com>
Cc: Mat Martineau <mathew.j.martineau@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, mptcp@lists.01.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mptcp: unify MPTCP_PM_MAX_ADDR and MPTCP_PM_ADDR_MAX
Date: Fri, 12 Jun 2020 19:33:11 +0200 [thread overview]
Message-ID: <2638593d-82bd-73be-8ff1-3a4a7d4d5968@tessares.net> (raw)
In-Reply-To: <463f48a4f92aa403453d30a801259c68fda15387.1591939496.git.geliangtang@gmail.com>
Hi Geliang,
On 12/06/2020 07:27, Geliang Tang wrote:
> Unify these two duplicate macros into 8.
Thank you for this new patch!
(...)
> diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
> index 809687d3f410..86d265500cf6 100644
> --- a/net/mptcp/protocol.h
> +++ b/net/mptcp/protocol.h
> @@ -135,7 +135,7 @@ static inline __be32 mptcp_option(u8 subopt, u8 len, u8 nib, u8 field)
> ((nib & 0xF) << 8) | field);
> }
>
> -#define MPTCP_PM_MAX_ADDR 4
> +#define MPTCP_PM_ADDR_MAX 8
I think it would be better to drop MPTCP_PM_MAX_ADDR and keep
MPTCP_PM_ADDR_MAX in pm_netlink.c where it is used. Each PM can decide
what's the maximum number of addresses it can support.
MPTCP_PM_MAX_ADDR seems to be a left over from a previous implementation
of a PM that has not been upstreamed but replaced by the Netlink PM later.
Also, please always add "net" or "net-next" prefix in the subject of
your email to help -net maintainers. Do not hesitate to look at the
netdev FAQ for more details.
Here this patch looks like a fix so you should have [PATCH net] and a
"Fixes" tag. I guess for this patch you can use:
Fixes: 1b1c7a0ef7f3 ("mptcp: Add path manager interface")
That's where MPTCP_PM_MAX_ADDR has been introduced. It was already not
used and never used later.
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2020-06-12 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 5:27 [PATCH] mptcp: unify MPTCP_PM_MAX_ADDR and MPTCP_PM_ADDR_MAX Geliang Tang
2020-06-12 17:33 ` Matthieu Baerts [this message]
2020-06-15 8:44 ` Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2638593d-82bd-73be-8ff1-3a4a7d4d5968@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=davem@davemloft.net \
--cc=geliangtang@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).