From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751651AbeCOQfX (ORCPT ); Thu, 15 Mar 2018 12:35:23 -0400 Received: from vern.gendns.com ([206.190.152.46]:60555 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbeCOQfW (ORCPT ); Thu, 15 Mar 2018 12:35:22 -0400 Subject: Re: [v2] ARM: davinci: fix the GPIO lookup for omapl138-hawk To: Bartosz Golaszewski , Sekhar Nori , Kevin Hilman , Russell King Cc: Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20180301103448.27233-1-brgl@bgdev.pl> From: David Lechner Message-ID: <2641a421-9823-c0bb-93d9-ca0c64060c51@lechnology.com> Date: Thu, 15 Mar 2018 11:35:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180301103448.27233-1-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/2018 04:34 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The GPIO chip is called davinci_gpio.0 in legacy mode. Fix it, so that > mmc can correctly lookup the wp and cp gpios. > > Fixes: c69f43fb4f26 ("ARM: davinci: hawk: use gpio descriptor for mmc pins") > Signed-off-by: Bartosz Golaszewski > Signed-off-by: Bartosz Golaszewski > Signed-off-by: Sekhar Nori > --- > v1 -> v2: > - added the Fixes: tag > > arch/arm/mach-davinci/board-omapl138-hawk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c > index a3e78074be70..62eb7d668890 100644 > --- a/arch/arm/mach-davinci/board-omapl138-hawk.c > +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c > @@ -127,8 +127,8 @@ static struct gpiod_lookup_table mmc_gpios_table = { > .dev_id = "da830-mmc.0", > .table = { > /* CD: gpio3_12: gpio60: chip 1 contains gpio range 32-63*/ > - GPIO_LOOKUP("davinci_gpio.1", 28, "cd", GPIO_ACTIVE_LOW), > - GPIO_LOOKUP("davinci_gpio.1", 29, "wp", GPIO_ACTIVE_LOW), > + GPIO_LOOKUP("davinci_gpio.0", 28, "cd", GPIO_ACTIVE_LOW), > + GPIO_LOOKUP("davinci_gpio.0", 29, "wp", GPIO_ACTIVE_LOW), > }, > }; > > Does board-da830-evm.c need the same fix? It also uses "davinci_gpio.1".