From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548AbeCUJ5z (ORCPT ); Wed, 21 Mar 2018 05:57:55 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:38925 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751455AbeCUJ5v (ORCPT ); Wed, 21 Mar 2018 05:57:51 -0400 From: Laurent Pinchart To: Arnd Bergmann Cc: Frank.Rowand@sony.com, David Airlie , niklas.soderlund+renesas@ragnatech.se, dri-devel , Linux-Renesas , Linux Kernel Mailing List , Frank Rowand Subject: Re: [PATCH] [RFC] drm: rcar-du: keep temporary dtb files around during build Date: Wed, 21 Mar 2018 11:58:57 +0200 Message-ID: <2654454.izifTNoijI@avalon> Organization: Ideas on Board Oy In-Reply-To: References: <20180315153730.3798004-1-arnd@arndb.de> <8748007.hiNNEuVPPY@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Wednesday, 21 March 2018 09:38:35 EET Arnd Bergmann wrote: > On Tue, Mar 20, 2018 at 9:15 PM, Laurent Pinchart wrote: > > On Friday, 16 March 2018 10:25:25 EET Arnd Bergmann wrote: > >> On Fri, Mar 16, 2018 at 2:39 AM, wrote: > >>> On Thursday, March 15, 2018 8:37 AM, Arnd Bergmann wrote: > >>>> The *.dtb and *.dtb.S files get removed by 'make' during the build > >>>> process, and later seem to be missed during the 'modpost' stage: > >>>> > >>>> rm drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dtb > >>>> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7791.dtb > >>>> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7791.dtb.S > >>>> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dtb.S > >>>> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb.S > >>>> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7793.dtb > >>>> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7796.dtb > >>>> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb > >>>> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7796.dtb.S > >>>> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7793.dtb.S > >>>> WARNING: could not open > >>>> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb.S: No such file or > >>>> directory > >>>> > >>>> As a workaround, this adds all those files to the 'extra-y' target > >>>> list, but that's really ugly. Any ideas for a better fix? > >>> > >>> Does this work for you (untested, but the way it is done in > >>> drivers/of/unittest-data/Makefile): > >>> > >>> .PRECIOUS: \ > >>> $(obj)/%.dtb.S \ > >>> $(obj)/%.dtb > >> > >> Yes, that works and looks much better than my version. > > > > Thank you for your patch, and sorry for breaking the build. Do you plan to > > submit a new version based on Frank's approach ? > > I'm currently at Linaro Connect and won't be able to send a tested patch > before mid next week. If you want it earlier, feel free to apply that patch > with my original description and 'Reported-by: Arnd Bergmann > '. I was about to do so, but realized I can't reproduce the problem here. If you don't mind I'll let you submit a v2. Alternatively I can work on it if you give me instruction to reproduce the issue. -- Regards, Laurent Pinchart