linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Alexander Antonov <alexander.antonov@linux.intel.com>,
	Alexei Budankov <abudankov@huawei.com>,
	Riccardo Mancini <rickyman7@gmail.com>
Subject: [PATCH v7 04/20] perf record: Stop threads in the end of trace streaming
Date: Tue, 22 Jun 2021 11:42:13 +0300	[thread overview]
Message-ID: <26565cdb34d0e0d310c5d89d591fdac178cced2e.1624350588.git.alexey.v.bayduraev@linux.intel.com> (raw)
In-Reply-To: <cover.1624350588.git.alexey.v.bayduraev@linux.intel.com>

Signal thread to terminate by closing write fd of msg pipe.
Receive THREAD_MSG__READY message as the confirmation of the
thread's termination. Stop threads created for parallel trace
streaming prior their stats processing.

Acked-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
---
 tools/perf/builtin-record.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 00d77e90d7c2..d30e0c5bece3 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -112,6 +112,16 @@ struct thread_data {
 
 static __thread struct thread_data *thread;
 
+enum thread_msg {
+	THREAD_MSG__UNDEFINED = 0,
+	THREAD_MSG__READY,
+	THREAD_MSG__MAX,
+};
+
+static const char *thread_msg_tags[THREAD_MSG__MAX] = {
+	"UNDEFINED", "READY"
+};
+
 struct record {
 	struct perf_tool	tool;
 	struct record_opts	opts;
@@ -1857,6 +1867,23 @@ static void record__uniquify_name(struct record *rec)
 	}
 }
 
+static int record__terminate_thread(struct thread_data *thread_data)
+{
+	int res;
+	enum thread_msg ack = THREAD_MSG__UNDEFINED;
+	pid_t tid = thread_data->tid;
+
+	close(thread_data->pipes.msg[1]);
+	res = read(thread_data->pipes.ack[0], &ack, sizeof(ack));
+	if (res != -1)
+		pr_debug2("threads[%d]: sent %s\n", tid, thread_msg_tags[ack]);
+	else
+		pr_err("threads[%d]: failed to recv msg=%s from tid=%d\n",
+		       thread->tid, thread_msg_tags[ack], tid);
+
+	return 0;
+}
+
 static int record__start_threads(struct record *rec)
 {
 	struct thread_data *thread_data = rec->thread_data;
@@ -1873,6 +1900,9 @@ static int record__stop_threads(struct record *rec, unsigned long *waking)
 	int t;
 	struct thread_data *thread_data = rec->thread_data;
 
+	for (t = 1; t < rec->nr_threads; t++)
+		record__terminate_thread(&thread_data[t]);
+
 	for (t = 0; t < rec->nr_threads; t++) {
 		rec->samples += thread_data[t].samples;
 		*waking += thread_data[t].waking;
-- 
2.19.0


  parent reply	other threads:[~2021-06-22  8:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22  8:42 [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 01/20] perf record: Introduce thread affinity and mmap masks Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 02/20] perf record: Introduce thread specific data array Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 03/20] perf record: Introduce thread local variable Alexey Bayduraev
2021-06-22  8:42 ` Alexey Bayduraev [this message]
2021-06-22  8:42 ` [PATCH v7 05/20] perf record: Start threads in the beginning of trace streaming Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 06/20] perf record: Introduce data file at mmap buffer object Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 07/20] perf record: Introduce data transferred and compressed stats Alexey Bayduraev
2021-06-30  8:05   ` Riccardo Mancini
2021-06-30 12:19     ` Bayduraev, Alexey V
2021-06-30 14:48       ` Bayduraev, Alexey V
2021-06-22  8:42 ` [PATCH v7 08/20] perf record: Init data file at mmap buffer object Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 09/20] tools lib: Introduce bitmap_intersects() operation Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 10/20] perf record: Introduce --threads=<spec> command line option Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 11/20] perf record: Document parallel data streaming mode Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 12/20] perf report: Output data file name in raw trace dump Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 13/20] perf session: Move reader structure to the top Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 14/20] perf session: Introduce reader_state in reader object Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 15/20] perf session: Introduce reader objects in session object Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 16/20] perf session: Introduce decompressor into trace reader object Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 17/20] perf session: Move init into reader__init function Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 18/20] perf session: Move map/unmap into reader__mmap function Alexey Bayduraev
2021-06-22  8:42 ` [PATCH v7 19/20] perf session: Load single file for analysis Alexey Bayduraev
2021-06-27  0:49   ` Namhyung Kim
2021-06-22  8:42 ` [PATCH v7 20/20] perf session: Load data directory files " Alexey Bayduraev
2021-06-30  6:14   ` Namhyung Kim
2021-06-27  0:46 ` [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation Namhyung Kim
2021-06-28  8:11   ` Bayduraev, Alexey V
2021-06-30  6:09     ` Namhyung Kim
2021-06-30  7:22       ` Bayduraev, Alexey V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26565cdb34d0e0d310c5d89d591fdac178cced2e.1624350588.git.alexey.v.bayduraev@linux.intel.com \
    --to=alexey.v.bayduraev@linux.intel.com \
    --cc=abudankov@huawei.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.antonov@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rickyman7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).