From: Logan Gunthorpe <logang@deltatee.com>
To: Paul Walmsley <paul.walmsley@sifive.com>,
Greentime Hu <green.hu@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
Andrew Waterman <andrew@sifive.com>,
Palmer Dabbelt <palmer@sifive.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stephen Bates <sbates@raithlin.com>,
linux-mm@vger.kernel.org, Olof Johansson <olof@lixom.net>,
greentime.hu@sifive.com, linux-riscv@lists.infradead.org,
Michael Clark <michaeljclark@mac.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 2/2] RISC-V: Implement sparsemem
Date: Wed, 14 Aug 2019 11:46:23 -0600 [thread overview]
Message-ID: <26594413-227b-2cc8-0f61-232a6a3907d0@deltatee.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1908141035020.18249@viisi.sifive.com>
On 2019-08-14 11:40 a.m., Paul Walmsley wrote:
> On Wed, 14 Aug 2019, Logan Gunthorpe wrote:
>
>> On 2019-08-14 7:35 a.m., Greentime Hu wrote:
>>
>>> Maybe this commit explains why it used HAVE_ARCH_PFN_VALID instead of SPARSEMEM.
>>> https://github.com/torvalds/linux/commit/7b7bf499f79de3f6c85a340c8453a78789523f85
>>>
>>> BTW, I found another issue here.
>>> #define FIXADDR_TOP (VMALLOC_START)
>>> #define FIXADDR_START (FIXADDR_TOP - FIXADDR_SIZE)
>>> #define VMEMMAP_END (VMALLOC_START - 1)
>>> #define VMEMMAP_START (VMALLOC_START - VMEMMAP_SIZE)
>>> These 2 regions are overlapped.
>>>
>>> How about this fix? Not sure if it is good for everyone.
>>
>> Yes, this looks good to me. I can fold these changes into my patch and
>> send a v5 to the list.
>
> The change to FIXADDR_TOP should be separated out into its own patch - it
> probably needs to go up as a fix.
I don't think so... VMEMMAP_START doesn't exist until the sparsemem
patch so it can't be changed until after the sparsemem patch and no
sense adding a bug in the sparsemem patch...
Logan
next prev parent reply other threads:[~2019-08-14 17:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 20:39 [PATCH v4 0/2] [PATCH v2 0/6] sparsemem support for RISC-V Logan Gunthorpe
2019-01-09 20:39 ` [PATCH v4 1/2] sh: mm: make use of new memblocks_present() helper Logan Gunthorpe
2019-01-15 13:58 ` Christoph Hellwig
2019-01-15 17:30 ` Logan Gunthorpe
2019-01-09 20:39 ` [PATCH v4 2/2] RISC-V: Implement sparsemem Logan Gunthorpe
2019-01-15 13:58 ` Christoph Hellwig
2019-07-31 6:30 ` Greentime Hu
2019-07-31 17:07 ` Logan Gunthorpe
2019-08-01 3:34 ` Greentime Hu
[not found] ` <CAEbi=3eZcgWevpX9VO9ohgxVDFVprk_t52Xbs3-TdtZ+js3NVA@mail.gmail.com>
2019-08-09 15:46 ` Logan Gunthorpe
2019-08-09 17:01 ` Greentime Hu
2019-08-09 19:03 ` Logan Gunthorpe
2019-08-12 4:01 ` Greentime Hu
2019-08-12 15:51 ` Logan Gunthorpe
2019-08-13 6:04 ` Greentime Hu
2019-08-13 16:14 ` Logan Gunthorpe
2019-08-13 16:39 ` Paul Walmsley
2019-08-13 16:48 ` Paul Walmsley
2019-08-13 16:49 ` Logan Gunthorpe
2019-08-14 13:35 ` Greentime Hu
2019-08-14 16:56 ` Logan Gunthorpe
2019-08-14 17:40 ` Paul Walmsley
2019-08-14 17:46 ` Logan Gunthorpe [this message]
2019-08-14 20:09 ` Paul Walmsley
2019-08-14 22:21 ` Logan Gunthorpe
2019-08-15 9:31 ` Greentime Hu
2019-08-15 16:20 ` Logan Gunthorpe
2019-08-16 2:07 ` Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26594413-227b-2cc8-0f61-232a6a3907d0@deltatee.com \
--to=logang@deltatee.com \
--cc=andrew@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=green.hu@gmail.com \
--cc=greentime.hu@sifive.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michaeljclark@mac.com \
--cc=olof@lixom.net \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).