From: Jiri Slaby <jslaby@suse.com>
To: Eric Biggers <ebiggers@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 2/2] tty: fix compat TIOCGSERIAL checking wrong function ptr
Date: Tue, 25 Feb 2020 08:30:19 +0100 [thread overview]
Message-ID: <265c9940-e274-2598-112a-35b66ab5001e@suse.com> (raw)
In-Reply-To: <20200224182044.234553-3-ebiggers@kernel.org>
On 24. 02. 20, 19:20, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Commit 77654350306a ("take compat TIOC[SG]SERIAL treatment into
> tty_compat_ioctl()") changed the compat version of TIOCGSERIAL to start
> checking for the presence of the ->set_serial function pointer rather
> than ->get_serial. This appears to be a copy-and-paste error, since
> ->get_serial is the function pointer that is called as well as the
> pointer that is checked by the non-compat version of TIOCGSERIAL.
>
> Fix this by checking the correct function pointer.
>
> Fixes: 77654350306a ("take compat TIOC[SG]SERIAL treatment into tty_compat_ioctl()")
> Cc: <stable@vger.kernel.org> # v4.20+
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Jiri Slaby <jslaby@suse.cz>
> ---
> drivers/tty/tty_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> index db4a13bc855ed6..5a6f36b391d95d 100644
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -2734,7 +2734,7 @@ static int compat_tty_tiocgserial(struct tty_struct *tty,
> memset(&v, 0, sizeof(v));
> memset(&v32, 0, sizeof(v32));
>
> - if (!tty->ops->set_serial)
> + if (!tty->ops->get_serial)
> return -ENOTTY;
> err = tty->ops->get_serial(tty, &v);
> if (!err) {
>
--
js
suse labs
prev parent reply other threads:[~2020-02-25 7:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 8:18 KMSAN: kernel-infoleak in tty_compat_ioctl syzbot
2020-02-24 8:38 ` [PATCH] tty: fix compat TIOCGSERIAL leaking uninitialized memory Eric Biggers
2020-02-24 8:47 ` Jiri Slaby
2020-02-24 18:15 ` Eric Biggers
2020-02-24 18:20 ` [PATCH v2 0/2] tty: fix bugs in compat TIOCGSERIAL Eric Biggers
2020-02-24 18:20 ` [PATCH v2 1/2] tty: fix compat TIOCGSERIAL leaking uninitialized memory Eric Biggers
2020-02-25 7:30 ` Jiri Slaby
2020-03-02 21:24 ` Eric Biggers
2020-03-03 6:29 ` Greg Kroah-Hartman
2020-03-18 12:00 ` Greg Kroah-Hartman
2020-03-18 16:36 ` Eric Biggers
2020-02-24 18:20 ` [PATCH v2 2/2] tty: fix compat TIOCGSERIAL checking wrong function ptr Eric Biggers
2020-02-25 7:30 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=265c9940-e274-2598-112a-35b66ab5001e@suse.com \
--to=jslaby@suse.com \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).