From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932387AbaJULty (ORCPT ); Tue, 21 Oct 2014 07:49:54 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:51447 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932170AbaJULtw (ORCPT ); Tue, 21 Oct 2014 07:49:52 -0400 From: "Rafael J. Wysocki" To: Michal Hocko Cc: Andrew Morton , Cong Wang , David Rientjes , Tejun Heo , Oleg Nesterov , LKML , linux-mm@kvack.org, Linux PM list Subject: Re: [PATCH 4/4] PM: convert do_each_thread to for_each_process_thread Date: Tue, 21 Oct 2014 14:10:18 +0200 Message-ID: <2670728.8H9BNSArM8@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1413876435-11720-5-git-send-email-mhocko@suse.cz> References: <1413876435-11720-1-git-send-email-mhocko@suse.cz> <1413876435-11720-5-git-send-email-mhocko@suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, October 21, 2014 09:27:15 AM Michal Hocko wrote: > as per 0c740d0afc3b (introduce for_each_thread() to replace the buggy > while_each_thread()) get rid of do_each_thread { } while_each_thread() > construct and replace it by a more error prone for_each_thread. > > This patch doesn't introduce any user visible change. > > Suggested-by: Oleg Nesterov > Signed-off-by: Michal Hocko ACK Or do you want me to handle this series? > --- > kernel/power/process.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/kernel/power/process.c b/kernel/power/process.c > index a397fa161d11..7fd7b72554fe 100644 > --- a/kernel/power/process.c > +++ b/kernel/power/process.c > @@ -46,13 +46,13 @@ static int try_to_freeze_tasks(bool user_only) > while (true) { > todo = 0; > read_lock(&tasklist_lock); > - do_each_thread(g, p) { > + for_each_process_thread(g, p) { > if (p == current || !freeze_task(p)) > continue; > > if (!freezer_should_skip(p)) > todo++; > - } while_each_thread(g, p); > + } > read_unlock(&tasklist_lock); > > if (!user_only) { > @@ -93,11 +93,11 @@ static int try_to_freeze_tasks(bool user_only) > > if (!wakeup) { > read_lock(&tasklist_lock); > - do_each_thread(g, p) { > + for_each_process_thread(g, p) { > if (p != current && !freezer_should_skip(p) > && freezing(p) && !frozen(p)) > sched_show_task(p); > - } while_each_thread(g, p); > + } > read_unlock(&tasklist_lock); > } > } else { > @@ -219,11 +219,11 @@ void thaw_processes(void) > thaw_workqueues(); > > read_lock(&tasklist_lock); > - do_each_thread(g, p) { > + for_each_process_thread(g, p) { > /* No other threads should have PF_SUSPEND_TASK set */ > WARN_ON((p != curr) && (p->flags & PF_SUSPEND_TASK)); > __thaw_task(p); > - } while_each_thread(g, p); > + } > read_unlock(&tasklist_lock); > > WARN_ON(!(curr->flags & PF_SUSPEND_TASK)); > @@ -246,10 +246,10 @@ void thaw_kernel_threads(void) > thaw_workqueues(); > > read_lock(&tasklist_lock); > - do_each_thread(g, p) { > + for_each_process_thread(g, p) { > if (p->flags & (PF_KTHREAD | PF_WQ_WORKER)) > __thaw_task(p); > - } while_each_thread(g, p); > + } > read_unlock(&tasklist_lock); > > schedule(); > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.