From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4ACC4338F for ; Sun, 25 Jul 2021 05:44:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE2FF600D4 for ; Sun, 25 Jul 2021 05:44:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbhGYFDk (ORCPT ); Sun, 25 Jul 2021 01:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbhGYFDi (ORCPT ); Sun, 25 Jul 2021 01:03:38 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAD6DC061757; Sat, 24 Jul 2021 22:44:08 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id jg2so5289486ejc.0; Sat, 24 Jul 2021 22:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QY+0BMkWlbBZLf8NjCu4UdB1W7Kp1V1Npts+uGib5k0=; b=OfKZvg5r05dTZaCPK0J/uk+0iq15RC9aVhh+9wIn3Do1byv+UFxgsOcGbtaLwKOvpj shkfpu7yLasiWRO875xuBO62BFWrWFuO12hDAb9oIitKl6xaeQ2eOIcnOq3kKyn5OHi6 NHqT/DyjCwv/DuaZedahmVWF5bXGePbfEs5ECMtoLG9jQsAdWnhwhk3mAr5jYPVBx72H WpK5Oszt+rWg/JjqOyMhNNsDj2XrcVlb8ChRzP/klbouEavFxiQpqBaNg+aOgDnBHf40 5/f6yhT4HkfaqkTHQltP/s7TgsLx+J/WyNWFnLlSzJssNNFZ6eLwsgpnEnHG4G2tG+t6 CWsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QY+0BMkWlbBZLf8NjCu4UdB1W7Kp1V1Npts+uGib5k0=; b=pUI9Vte/I+fAJb0CwKkVsIrlApHtsltLGfPxG4QidcHUhyyAfx+EFJ6ETHYHeYhTsT 08WySgj3CgSeu6GjrfeCrWnkHDFG7bauxwJob9NuxMqPf4Z3pfarqZDq80Kjlv2LuJv0 86tF3DGLcUP8Fr3mgTGGmRH62rStUZl6xv2BLz9HJgUeTSKL7savEKGwpC0cmkgk2Q5A LfjC5MyfxATKAHRcUXNNj0onsoHSaDAAxPjqGJJNXORxIinRpAZGgFpNUk48sutyk1ea DvC09XDMo1F9uGaXxeLIaVSfp1ht6jO0cmew5CJW9l5S303S+pCJrPhRwXMMBKI49vn9 rlVw== X-Gm-Message-State: AOAM532DZovYPvhs6w2z6XBkyBXIh22XOV3h3lEeTK5cqjmgHo6S/Amg J3kVrAuJkdgBl2INBfOGNs14wtRtFPBXmfgt X-Google-Smtp-Source: ABdhPJznzroxcAGpmNL3owvGqD5iDjbHdakw9PGzF8T5rjlETybHcPm7OqrxGEby6yJN4NtOxlbqsA== X-Received: by 2002:a17:906:24d3:: with SMTP id f19mr654767ejb.391.1627191847250; Sat, 24 Jul 2021 22:44:07 -0700 (PDT) Received: from kista.localnet (cpe-86-58-46-198.static.triera.net. [86.58.46.198]) by smtp.gmail.com with ESMTPSA id op23sm13069188ejb.7.2021.07.24.22.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 22:44:06 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , Chen-Yu Tsai , Andre Przywara Cc: Rob Herring , Icenowy Zheng , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ondrej Jirman , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v8 03/11] rtc: sun6i: Fix time overflow handling Date: Sun, 25 Jul 2021 07:44:05 +0200 Message-ID: <2672991.hCPy0aSqvS@kista> In-Reply-To: <20210723153838.6785-4-andre.przywara@arm.com> References: <20210723153838.6785-1-andre.przywara@arm.com> <20210723153838.6785-4-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andre! Dne petek, 23. julij 2021 ob 17:38:30 CEST je Andre Przywara napisal(a): > Using "unsigned long" for UNIX timestamps is never a good idea, and > comparing the value of such a variable against U32_MAX does not do > anything useful on 32-bit systems. > > Use the proper time64_t type when dealing with timestamps, and avoid > cutting down the time range unnecessarily. This also fixes the flawed > check for the alarm time being too far into the future. > > The check for this condition is actually somewhat theoretical, as the > RTC counts till 2033 only anyways, and 2^32 seconds from now is not > before the year 2157 - at which point I hope nobody will be using this > hardware anymore. > > Signed-off-by: Andre Przywara > --- > drivers/rtc/rtc-sun6i.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) Reviewed-by: Jernej Skrabec Best regards, Jernej