linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Jann Horn <jannh@google.com>
Cc: dhowells@redhat.com, Amol Grover <frextrite@gmail.com>,
	Shakeel Butt <shakeelb@google.com>,
	James Morris <jamorris@linux.microsoft.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Joel Fernandes <joel@joelfernandes.org>,
	Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH] cred: Use RCU primitives to access RCU pointers
Date: Fri, 31 Jan 2020 17:49:49 +0000	[thread overview]
Message-ID: <267885.1580492989@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAG48ez3ZcO+kVPJVG6XpCPyGUKF2o4UJ6AVdgZXGQ6XJJpcdmg@mail.gmail.com>

Jann Horn <jannh@google.com> wrote:

> > task_struct.cred and task_struct.real_cred are annotated by __rcu,
> 
> task_struct.cred doesn't actually have RCU semantics though, see
> commit d7852fbd0f0423937fa287a598bfde188bb68c22. For task_struct.cred,
> it would probably be more correct to remove the __rcu annotation?

You're right, I think, there shouldn't be any need for __rcu on
task_struct::cred since it shouldn't be accessed on any task except current.

I've a feeling that there was something at the time, proc perhaps, but I don't
remember.

David


      parent reply	other threads:[~2020-01-31 17:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28  7:27 [PATCH] cred: Use RCU primitives to access RCU pointers Amol Grover
2020-01-28  9:30 ` Jann Horn
2020-01-28 11:48   ` Oleg Nesterov
2020-01-28 12:19     ` Jann Horn
2020-01-28 12:38       ` Oleg Nesterov
2020-01-28 17:04   ` Amol Grover
2020-01-28 19:09     ` Jann Horn
2020-01-29  6:57       ` Amol Grover
2020-01-29 14:14         ` Jann Horn
2020-02-06  1:32           ` Joel Fernandes
2020-02-06 11:28             ` Jann Horn
2020-02-06 16:49               ` Joel Fernandes
2020-02-06 17:15                 ` Jann Horn
2020-02-06 18:08                   ` Joel Fernandes
2020-02-06 13:09             ` Amol Grover
2020-01-28 15:00 ` David Howells
2020-01-31 17:49 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=267885.1580492989@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=frextrite@gmail.com \
    --cc=jamorris@linux.microsoft.com \
    --cc=jannh@google.com \
    --cc=joel@joelfernandes.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madhuparnabhowmik04@gmail.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=shakeelb@google.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).