Re: [PATCH v2 6/8] DT: arm: exynos: add DMC device for exynos5422

[Lukasz Luba <l.luba@partner.samsung.com>]

Hi Krzysztof,

On 1/30/19 10:46 AM, Krzysztof Kozlowski wrote:
> On Tue, 29 Jan 2019 at 18:55, Lukasz Luba <l.luba@partner.samsung.com> wrote:
>>
>> Add description of Dynamic Memory Controller and PPMU counters.
>> They are used by exynos5422-dmc driver.
>>
>> CC: Rob Herring <robh+dt@kernel.org>
>> CC: Mark Rutland <mark.rutland@arm.com>
>> CC: Kukjin Kim <kgene@kernel.org>
>> CC: Krzysztof Kozlowski <krzk@kernel.org>
>> CC: devicetree@vger.kernel.org
>> CC: linux-arm-kernel@lists.infradead.org
>> CC: linux-samsung-soc@vger.kernel.org
>> CC: linux-kernel@vger.kernel.org
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5420.dtsi             | 69 +++++++++++++++++++++++++++
>>   arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 22 +++++++++
>>   2 files changed, 91 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index aaff158..4d76335 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -235,6 +235,27 @@
>>                          status = "disabled";
>>                  };
>>
>> +               dmc: memory-controller@10c20000 {
>> +                       compatible = "samsung,exynos5422-dmc";
>> +                       reg = <0x10c20000 0x10000>, <0x10c30000 0x10000>,
>> +                               <0x10030000 0x1000>, <0x10000000 0x1000>;
>> +                       clocks = <&clock CLK_FOUT_SPLL>,
>> +                               <&clock CLK_MOUT_SCLK_SPLL>,
>> +                               <&clock CLK_FF_DOUT_SPLL2>,
>> +                               <&clock CLK_FOUT_BPLL>, <&clock CLK_MOUT_BPLL>,
>> +                               <&clock CLK_SCLK_BPLL>,
>> +                               <&clock CLK_MOUT_MX_MSPLL_CCORE>,
>> +                               <&clock CLK_MOUT_MX_MSPLL_CCORE_PHY>,
>> +                               <&clock CLK_MOUT_MCLK_CDREX>,
>> +                               <&clock CLK_DOUT_CLK2X_PHY0>,
>> +                               <&clock CLK_CLKM_PHY0>, <&clock CLK_CLKM_PHY1>;
>> +                       clock-names = "fout_spll", "mout_sclk_spll",
>> +                               "ff_dout_spll2", "fout_bpll", "mout_bpll",
>> +                               "sclk_bpll", "mout_mx_mspll_ccore",
>> +                               "mout_mx_mspll_ccore_phy", "mout_mclk_cdrex",
>> +                               "dout_clk2x_phy0", "clkm_phy0", "clkm_phy1";
> 
> We misunderstood each other. I did not ask for compaction into one
> continued line but for proper indentation. Having one entry per one
> line was fine because you have really a lot of entries and it was
> making things easier to check.
> It should look like:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/exynos54xx.dtsi?h=v4.20#n78
> 
Yes, we misunderstood each other. I will fix it in v3.
Thank you for having a look on it. I assume that the other issues
have been properly addressed.

Regards,
Lukasz

> Best regards,
> Krzysztof
> 
>