From: Ross Philipson <ross.philipson@oracle.com>
To: Dave Hansen <dave.hansen@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Cc: dpsmith@apertussolutions.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
luto@amacapital.net, dave.hansen@linux.intel.com,
kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com,
jailhouse-dev@googlegroups.com, jan.kiszka@siemens.com,
xen-devel@lists.xenproject.org, jgross@suse.com,
boris.ostrovsky@oracle.com, andrew.cooper3@citrix.com
Subject: Re: [PATCH v2 1/2] x86: Check return values from early_memremap calls
Date: Thu, 10 Nov 2022 14:30:26 -0500 [thread overview]
Message-ID: <267d84e3-3fbe-f010-113a-805763b7a325@oracle.com> (raw)
In-Reply-To: <8e62a029-f2fa-0627-1f71-4850a68ec6b6@intel.com>
On 11/10/22 11:07, Dave Hansen wrote:
> On 11/10/22 07:45, Ross Philipson wrote:
>> dt = early_memremap(initial_dtb, map_len);
>> + if (!dt) {
>> + pr_warn("failed to memremap initial dtb\n");
>> + return;
>> + }
>
> Are all of these new pr_warn/err()'s really adding much value? They all
> look pretty generic. It makes me wonder if we should just spit out a
> generic message in early_memremap() and save all the callers the trouble.
These changes were prompted by some comments on an earlier patch set I
sent. It was requested that I fix the other missing checks for NULL
returns from these functions but I thought that was out of scope for
that patch set. So I agreed to submit this set and add the checks making
things consistent.
>
> Oh, and don't we try to refer to functions() with parenthesis?
Yes I can fix that.
Thanks
Ross
>
next prev parent reply other threads:[~2022-11-10 20:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 15:45 [PATCH v2 0/2] x86: Check return values for early memory/IO remap calls Ross Philipson
2022-11-10 15:45 ` [PATCH v2 1/2] x86: Check return values from early_memremap calls Ross Philipson
2022-11-10 16:07 ` Juergen Gross
2022-11-10 16:07 ` Dave Hansen
2022-11-10 19:30 ` Ross Philipson [this message]
2023-01-04 11:58 ` Borislav Petkov
2022-11-10 15:45 ` [PATCH v2 2/2] x86: Check return values from early_ioremap calls Ross Philipson
2022-11-10 18:07 ` Peter Zijlstra
2022-11-10 19:31 ` Ross Philipson
2023-01-03 20:36 ` [PATCH v2 0/2] x86: Check return values for early memory/IO remap calls Ross Philipson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=267d84e3-3fbe-f010-113a-805763b7a325@oracle.com \
--to=ross.philipson@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dpsmith@apertussolutions.com \
--cc=hpa@zytor.com \
--cc=jailhouse-dev@googlegroups.com \
--cc=jan.kiszka@siemens.com \
--cc=jgross@suse.com \
--cc=kanth.ghatraju@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=trenchboot-devel@googlegroups.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).