From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Mark Brown <broonie@kernel.org>,
linux-arm-msm@vger.kernel.org,
Kenneth Westfield <kwestfie@codeaurora.org>,
Kevin Hilman <khilman@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "ASoC: qcom: Specify LE device endianness"
Date: Fri, 12 Feb 2016 20:48:58 +0100 [thread overview]
Message-ID: <2686474.cvCA6vY47l@wuerfel> (raw)
In-Reply-To: <1455298217-15744-1-git-send-email-sboyd@codeaurora.org>
On Friday 12 February 2016 09:30:17 Stephen Boyd wrote:
> This reverts commit 18560a4e3b07438113b50589e78532d95f907029.
>
> The commit that caused us to specify LE device endianness here,
> 29bb45f25ff3 (regmap-mmio: Use native endianness for read/write,
> 2015-10-29), has been reverted in mainline so now when we specify
> LE it actively breaks big endian kernels because the byte
> swapping in regmap-mmio is incorrect. Let's revert this change
> because it will 1) fix the big endian kernels and 2) be redundant
> to specify LE because that will become the default soon.
>
> Cc: Kenneth Westfield <kwestfie@codeaurora.org>
> Cc: Kevin Hilman <khilman@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Ah, too bad to have to revert a correct change until the infrastructure
is fixed properly, but I guess it's the easier way out here.
What about the other uses of REGMAP_ENDIAN_LITTLE in the kernel?
In particular I see
drivers/clk/nxp/clk-lpc32xx.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/gcc-apq8084.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/gcc-ipq806x.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/gcc-msm8660.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/gcc-msm8916.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/gcc-msm8960.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/gcc-msm8960.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/gcc-msm8974.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/lcc-ipq806x.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/lcc-msm8960.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/mmcc-apq8084.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/mmcc-msm8960.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/mmcc-msm8960.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/clk/qcom/mmcc-msm8974.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/nvmem/qfprom.c: .val_format_endian = REGMAP_ENDIAN_LITTLE,
and of course
drivers/mfd/syscon.c: syscon_config.val_format_endian = REGMAP_ENDIAN_LITTLE;
which all look like they are regmap_mmio users as well. Do they
suffer from the same problem?
Arnd
next prev parent reply other threads:[~2016-02-12 19:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 17:30 [PATCH] Revert "ASoC: qcom: Specify LE device endianness" Stephen Boyd
2016-02-12 19:34 ` Mark Brown
2016-02-12 19:48 ` Arnd Bergmann [this message]
2016-02-12 20:03 ` Mark Brown
2016-02-12 20:35 ` Arnd Bergmann
2016-02-12 21:28 ` Mark Brown
2016-02-12 22:08 ` Stephen Boyd
2016-02-12 21:26 ` Mark Brown
2016-02-12 22:04 ` Stephen Boyd
2016-02-12 22:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2686474.cvCA6vY47l@wuerfel \
--to=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=khilman@linaro.org \
--cc=kwestfie@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).