From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751468AbdKUTqB (ORCPT ); Tue, 21 Nov 2017 14:46:01 -0500 Received: from mail.z3ntu.xyz ([128.199.32.197]:34644 "EHLO mail.z3ntu.xyz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbdKUTp7 (ORCPT ); Tue, 21 Nov 2017 14:45:59 -0500 X-Greylist: delayed 443 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Nov 2017 14:45:58 EST From: Luca Weiss To: Bjorn Andersson Cc: Adrian Hunter , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Stephen Boyd , Sahitya Tummala , Vijay Viswanath Subject: Re: [v2] mmc: sdhci-msm: Optionally wait for signal level changes Date: Tue, 21 Nov 2017 20:38:31 +0100 Message-ID: <2689768.7AuDOzprkX@g550jk> In-Reply-To: <20171120195647.22677-1-bjorn.andersson@linaro.org> References: <20171120195647.22677-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Montag, 20. November 2017 20:56:47 CET Bjorn Andersson wrote: > Not all instances of the SDCC core supports changing signal voltage and > as such will not generate a power interrupt when the software attempts > to change the voltage. This results in probing the eMMC on some devices > to take over 2 minutes. > > Check that the SWITCHABLE_SIGNALING_VOLTAGE bit in MCI_GENERICS is set > before waiting for the power interrupt. > > Cc: Sahitya Tummala > Cc: Vijay Viswanath > Fixes: c0309b3803fe ("mmc: sdhci-msm: Add sdhci msm register write APIs > which wait for pwr irq") Signed-off-by: Bjorn Andersson > Tested-by: Luca Weiss > --- > > The offending patch is part of your v4.15 pull request, so please pick > this up for the -rcs. > > Changes since v1: > - Fixed spelling of swichable... > > drivers/mmc/host/sdhci-msm.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index 3fb7d2eec93f..c283291db705 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -29,6 +29,9 @@ > #define CORE_VERSION_MAJOR_MASK (0xf << CORE_VERSION_MAJOR_SHIFT) > #define CORE_VERSION_MINOR_MASK 0xff > > +#define CORE_MCI_GENERICS 0x70 > +#define SWITCHABLE_SIGNALING_VOLTAGE BIT(29) > + > #define CORE_HC_MODE 0x78 > #define HC_MODE_EN 0x1 > #define CORE_POWER 0x0 > @@ -1028,11 +1031,22 @@ static void sdhci_msm_check_power_status(struct > sdhci_host *host, u32 req_type) struct sdhci_pltfm_host *pltfm_host = > sdhci_priv(host); > struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host); > bool done = false; > + u32 val; > > pr_debug("%s: %s: request %d curr_pwr_state %x curr_io_level %x\n", > mmc_hostname(host->mmc), __func__, req_type, > msm_host->curr_pwr_state, msm_host->curr_io_level); > > + /* > + * The power interrupt will not be generated for signal voltage > + * switches if SWITCHABLE_SIGNALING_VOLTAGE in MCI_GENERICS is not set. > + */ > + val = readl(msm_host->core_mem + CORE_MCI_GENERICS); > + if ((req_type & REQ_IO_HIGH || req_type & REQ_IO_LOW) && > + !(val & SWITCHABLE_SIGNALING_VOLTAGE)) { > + return; > + } > + > /* > * The IRQ for request type IO High/LOW will be generated when - > * there is a state change in 1.8V enable bit (bit 3) of