From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5CD6C61DA4 for ; Mon, 6 Mar 2023 12:38:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbjCFMiw (ORCPT ); Mon, 6 Mar 2023 07:38:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbjCFMit (ORCPT ); Mon, 6 Mar 2023 07:38:49 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85DB4206A4 for ; Mon, 6 Mar 2023 04:38:40 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id ay29-20020a05600c1e1d00b003e9f4c2b623so8067712wmb.3 for ; Mon, 06 Mar 2023 04:38:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678106319; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2yhOmJgcVtUjX4AZDns6YBklpfVzqtsQV67rhvEp3eI=; b=OR7LWTSNoXH3IeQrctqw8TkU9wgsDdXVChDKrhxA8J3CgRJrceNUjn3osYOwFrOrRN BqqlMX0IExW5kP5JBmTfrA9H6By8K1zl4rGuH1LTTyOpV5B8hGX8uTw2I8X2fD+RGPEA TBezyt2nk9lhD30IBNuJVbxD900xHxrW6/nzN1UwiGKAu5FHVTGUOlj/bKC/M4kdoYuh XrZfp6Fr9Unp7AGBU0X2aBck0rgdcZOe5CBXNixWbswNuXtub9Ll7ByzbpqSN63Rlj+B 27YWkSWMquule9G7VP35cEtfD2mRLvx+suAdrWg6FWxZdVxw4OXauD5rIAeN7OX+ccjk s1yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678106319; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2yhOmJgcVtUjX4AZDns6YBklpfVzqtsQV67rhvEp3eI=; b=pFEMh3kWTRB9T6cvbEPDbXHtuMIySbQ8Jt47d3B9O0l1PJ8jFy/NtXCE2aW/Ky8tYW E9h3YI6UTonsECveqldyN2506a5abt3X2v/e2TrZv7V/t+PlG8jBZjGUl/JwLkwh/1Gs kKOsrO2E9C6JSjh2D+LaPAAOBMALHqPA+LqNYbzt7eB+eOTHdLGrdWxTPYA8AzM0+D7P 5J8Bg73KQZtECUxosfj84s/gJuR/WzaTq6/KdVUIegtoRhDVPCToEY3Q1aaU77Hs16JY 0jvO0ksNvy909pVraDNhn7At30FxQIUcFRmBR2VBL3YeChFVlrrO5OmFLtXNuNH6FG/s S46w== X-Gm-Message-State: AO0yUKVRAHnHqQPLfJSYnsG/ArB4DR2fWQnc3S2A2bCCvOd2JWFCJbI5 zBnbfEyhJndtTNyV6F1WcfTudQ== X-Google-Smtp-Source: AK7set9TvA7YNerqLQ/yes/5QTT3xBVyyZhcuMwk68DQMGSIOInAXFM8jDVPJH5zS95nzX34Pm6YEw== X-Received: by 2002:a05:600c:468b:b0:3e2:589:2502 with SMTP id p11-20020a05600c468b00b003e205892502mr8583211wmo.28.1678106318988; Mon, 06 Mar 2023 04:38:38 -0800 (PST) Received: from [10.203.3.194] ([185.202.34.81]) by smtp.gmail.com with ESMTPSA id r18-20020a05600c35d200b003dfe549da4fsm14827701wmq.18.2023.03.06.04.38.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 04:38:38 -0800 (PST) Message-ID: <26986caf-1245-88f2-60d0-5930c86ea31b@linaro.org> Date: Mon, 6 Mar 2023 14:38:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 09/10] drm/msm: use drmm_mode_config_init() Content-Language: en-GB To: Johan Hovold , Rob Clark , Abhinav Kumar Cc: Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230306100722.28485-1-johan+linaro@kernel.org> <20230306100722.28485-10-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20230306100722.28485-10-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2023 12:07, Johan Hovold wrote: > Switch to using drmm_mode_config_init() so that the mode config is > released when the last reference to the DRM device is dropped rather > than unconditionally at unbind() (which may be too soon). This also means that drm_bridge_detach() might be called at some point after unbind(), which might be too late. > > Signed-off-by: Johan Hovold > --- > drivers/gpu/drm/msm/msm_drv.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 73c597565f99..ade17947d1e5 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -247,8 +247,6 @@ static int msm_drm_uninit(struct device *dev) > if (kms) > msm_disp_snapshot_destroy(ddev); > > - drm_mode_config_cleanup(ddev); > - > for (i = 0; i < priv->num_bridges; i++) > drm_bridge_remove(priv->bridges[i]); > priv->num_bridges = 0; > @@ -454,11 +452,13 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) > might_lock(&priv->lru.lock); > fs_reclaim_release(GFP_KERNEL); > > - drm_mode_config_init(ddev); > + ret = drmm_mode_config_init(ddev); > + if (ret) > + goto err_destroy_wq; > > ret = msm_init_vram(ddev); > if (ret) > - goto err_cleanup_mode_config; > + goto err_destroy_wq; > > /* Bind all our sub-components: */ > ret = component_bind_all(dev, ddev); > @@ -563,8 +563,7 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) > > err_deinit_vram: > msm_deinit_vram(ddev); > -err_cleanup_mode_config: > - drm_mode_config_cleanup(ddev); > +err_destroy_wq: > destroy_workqueue(priv->wq); > err_put_dev: > drm_dev_put(ddev); -- With best wishes Dmitry