From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45EFC43387 for ; Fri, 11 Jan 2019 18:46:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B556C20878 for ; Fri, 11 Jan 2019 18:46:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390083AbfAKSqX convert rfc822-to-8bit (ORCPT ); Fri, 11 Jan 2019 13:46:23 -0500 Received: from mga05.intel.com ([192.55.52.43]:43977 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728927AbfAKSqX (ORCPT ); Fri, 11 Jan 2019 13:46:23 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2019 10:46:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,466,1539673200"; d="scan'208";a="105915380" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga007.jf.intel.com with ESMTP; 11 Jan 2019 10:46:22 -0800 Received: from orsmsx104.amr.corp.intel.com ([169.254.4.11]) by ORSMSX107.amr.corp.intel.com ([169.254.1.32]) with mapi id 14.03.0415.000; Fri, 11 Jan 2019 10:46:22 -0800 From: "Bowers, AndrewX" To: "intel-wired-lan@lists.osuosl.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [Intel-wired-lan] [PATCH] ixgbe: remove magic constant in ixgbe_reset_hw_82599() Thread-Topic: [Intel-wired-lan] [PATCH] ixgbe: remove magic constant in ixgbe_reset_hw_82599() Thread-Index: AQHUotKoDnZiRZ5LM02zKH+JAqXauaWqditQ Date: Fri, 11 Jan 2019 18:46:22 +0000 Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A1D3510C4@ORSMSX104.amr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWE2ZWJhZTgtYzIxZi00MjZmLThkODktOWYwNzlhZDllYjVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZGtcL3FldkpjVFZNbSs4OFJJWW5GSHJLT2t0ZTgxd0dpblVPN1hwUVlHRFhMZjdud2JPQnhmWVdXRTRoVmg2SEkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Jiri Kosina > Sent: Wednesday, January 2, 2019 11:21 AM > To: Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux- > kernel@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] ixgbe: remove magic constant in > ixgbe_reset_hw_82599() > > From: Jiri Kosina > > ixgbe_reset_hw_82599() resets the value of hw->mac.num_rar_entries to > pre-defined value of 128. Let's get rid of that hardcoded literal, and use > IXGBE_82599_RAR_ENTRIES instead, the same way the normal initialization > path does. > > Signed-off-by: Jiri Kosina > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Andrew Bowers