linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Rob Herring <robh@kernel.org>, matthias.bgg@kernel.org
Cc: mturquette@baylibre.com, sboyd@kernel.org,
	allen-kh.cheng@mediatek.com, weiyi.lu@mediatek.com,
	chun-jie.chen@mediatek.com, linux-kernel@vger.kernel.org,
	ikjn@chromium.org, miles.chen@mediatek.com,
	linux-mediatek@lists.infradead.org,
	krzysztof.kozlowski+dt@linaro.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	angelogioacchino.delregno@collabora.com,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
Date: Thu, 5 May 2022 18:47:30 +0200	[thread overview]
Message-ID: <26c2fb0c-e58a-5864-4256-f60f948ca634@gmail.com> (raw)
In-Reply-To: <YnGjScfQA9axBYBO@robh.at.kernel.org>



On 03/05/2022 23:48, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 02:31:31PM +0200, matthias.bgg@kernel.org wrote:
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
> 
> An ABI break is okay because ...?
> 

Because the code controlling the clock gate was moved to the consumer. This node 
did never ever represent any working implementation of a peripheral. Just a 
lonely clock gate that wasn't used.

Regards,
Matthias

>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - Delete compatible in binding descprition as well
>>
>>   .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
>>   1 file changed, 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> index c8c67c033f8c..b57cc2e69efb 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> @@ -24,7 +24,6 @@ properties:
>>             - mediatek,mt8192-imp_iic_wrap_w
>>             - mediatek,mt8192-imp_iic_wrap_n
>>             - mediatek,mt8192-msdc_top
>> -          - mediatek,mt8192-msdc
>>             - mediatek,mt8192-mfgcfg
>>             - mediatek,mt8192-imgsys
>>             - mediatek,mt8192-imgsys2
>> @@ -107,13 +106,6 @@ examples:
>>           #clock-cells = <1>;
>>       };
>>   
>> -  - |
>> -    msdc: clock-controller@11f60000 {
>> -        compatible = "mediatek,mt8192-msdc";
>> -        reg = <0x11f60000 0x1000>;
>> -        #clock-cells = <1>;
>> -    };
>> -
>>     - |
>>       mfgcfg: clock-controller@13fbf000 {
>>           compatible = "mediatek,mt8192-mfgcfg";
>> -- 
>> 2.34.1
>>
>>

  parent reply	other threads:[~2022-05-05 16:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29 12:31 [PATCH v2 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate") matthias.bgg
2022-04-29 12:31 ` [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock matthias.bgg
2022-04-29 13:31   ` AngeloGioacchino Del Regno
2022-04-30 23:14   ` Miles Chen
2022-05-03 21:48   ` Rob Herring
2022-05-05  5:31     ` [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock Miles Chen
2022-05-09 22:36       ` Rob Herring
2022-05-09 23:18         ` Miles Chen
2022-05-05 16:47     ` Matthias Brugger [this message]
2022-05-20 22:21       ` [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock Stephen Boyd
2022-04-29 12:31 ` [PATCH v2 2/2] clk: mediatek: Delete MT8192 msdc gate matthias.bgg
2022-04-30 23:14   ` Miles Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26c2fb0c-e58a-5864-4256-f60f948ca634@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=allen-kh.cheng@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chun-jie.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ikjn@chromium.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@kernel.org \
    --cc=miles.chen@mediatek.com \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=weiyi.lu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).