From: <Tudor.Ambarus@microchip.com>
To: <Claudiu.Beznea@microchip.com>, <Ludovic.Desroches@microchip.com>,
<vkoul@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] dmaengine: at_xdmac: use pm_ptr()
Date: Fri, 15 Oct 2021 08:03:06 +0000 [thread overview]
Message-ID: <26d866bb-7a6d-d3b7-953f-caeb6249eacc@microchip.com> (raw)
In-Reply-To: <20211007111230.2331837-5-claudiu.beznea@microchip.com>
On 10/7/21 2:12 PM, Claudiu Beznea wrote:
> Use pm_ptr() macro to fill at_xdmac_driver.driver.pm.
I would amend the commit message with:
If CONFIG_PM is enabled, this macro will resolve to its argument,
otherwise to NULL.
Nitpick anyway, so:
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/dma/at_xdmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 12371396fcc0..7fb19bd18ac3 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -2231,7 +2231,7 @@ static struct platform_driver at_xdmac_driver = {
> .driver = {
> .name = "at_xdmac",
> .of_match_table = of_match_ptr(atmel_xdmac_dt_ids),
> - .pm = &atmel_xdmac_dev_pm_ops,
> + .pm = pm_ptr(&atmel_xdmac_dev_pm_ops),
> }
> };
>
>
next prev parent reply other threads:[~2021-10-15 8:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 11:12 [PATCH 0/4] dmaengine: at_xdmac: fixes and code enhancements Claudiu Beznea
2021-10-07 11:12 ` [PATCH 1/4] dmaengine: at_xdmac: call at_xdmac_axi_config() on resume path Claudiu Beznea
2021-10-15 7:49 ` Tudor.Ambarus
2021-10-07 11:12 ` [PATCH 2/4] dmaengine: at_xdmac: fix AT_XDMAC_CC_PERID() macro Claudiu Beznea
2021-10-15 7:50 ` Tudor.Ambarus
2021-10-07 11:12 ` [PATCH 3/4] dmaengine: at_xdmac: use __maybe_unused for pm functions Claudiu Beznea
2021-10-15 8:01 ` Tudor.Ambarus
2021-10-07 11:12 ` [PATCH 4/4] dmaengine: at_xdmac: use pm_ptr() Claudiu Beznea
2021-10-15 8:03 ` Tudor.Ambarus [this message]
2021-10-18 6:12 ` [PATCH 0/4] dmaengine: at_xdmac: fixes and code enhancements Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26d866bb-7a6d-d3b7-953f-caeb6249eacc@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).