From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Joe Perches <joe@perches.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] lib: remove leading spaces before tabs
Date: Wed, 9 Jun 2021 13:15:04 +0800 [thread overview]
Message-ID: <26ee1009-259d-07a6-495f-87557be9ed8a@huawei.com> (raw)
In-Reply-To: <8a70d592e14f93822bf40832c7374d8e491c3afc.camel@perches.com>
On 2021/6/9 0:03, Joe Perches wrote:
> On Tue, 2021-06-08 at 17:00 +0800, Leizhen (ThunderTown) wrote:
>> On 2021/6/8 16:44, Andy Shevchenko wrote:
>>> On Tue, Jun 8, 2021 at 10:14 AM Zhen Lei <thunder.leizhen@huawei.com> wrote:
>>>>
>>>> 1) Run the following command to find and remove the leading spaces before
>>>> tabs:
>>>> find lib/ -type f | xargs sed -r -i 's/^[ ]+\t/\t/'
>>>
>>> Hint for the future, try to use what Git provides, for example `git
>>> ls-files -- lib/`.
>>
>> Okay, thanks. I learned a new trick.
>
> Perhaps another 'trick'.
>
> checkpatch has SPACE_BEFORE_TAB which does this for any spaces before
> a tab, not just at the start of lines. But as you've no doubt seen,
> many maintainers do not care for this sort of whitespace only change
> so it's best to do this sparingly or only in drivers/staging/ paths.
I've always thought of kernel, mm, and lib as the core modules of Linux,
and they serve as showcases for successors. I'm not interested in making
coding style improvements unless it's a work-related driver that I
usually read.
>
> For instance:
>
> $ git diff --stat lib
> $ git ls-files lib/ | \
> xargs ./scripts/checkpatch.pl --types=SPACE_BEFORE_TAB --fix-inplace
Wow, It's so powerful. Thanks.
> <checkpatch output>
> $ git diff --stat lib
> lib/atomic64_test.c | 2 +-
> lib/bitmap.c | 4 +-
> lib/btree.c | 4 +-
> lib/decompress_bunzip2.c | 6 +-
> lib/fonts/font_mini_4x6.c | 512 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------
This file is horrible. It's hard not to correct it.
> lib/locking-selftest.c | 12 ++--
> lib/lockref.c | 2 +-
> lib/lru_cache.c | 2 +-
> lib/math/rational-test.c | 2 +-
> lib/nlattr.c | 4 +-
> lib/raid6/neon.c | 2 +-
> lib/raid6/sse2.c | 12 ++--
> lib/reed_solomon/reed_solomon.c | 4 +-
> lib/scatterlist.c | 4 +-
> lib/string.c | 4 +-
> lib/test_firmware.c | 2 +-
> lib/test_kmod.c | 2 +-
> lib/test_overflow.c | 2 +-
> lib/textsearch.c | 2 +-
> lib/ts_bm.c | 2 +-
> lib/zlib_deflate/deflate.c | 2 +-
> 21 files changed, 294 insertions(+), 294 deletions(-)
>
>
>
> .
>
next prev parent reply other threads:[~2021-06-09 5:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 7:14 [PATCH 1/1] lib: remove leading spaces before tabs Zhen Lei
2021-06-08 8:44 ` Andy Shevchenko
2021-06-08 9:00 ` Leizhen (ThunderTown)
2021-06-08 16:03 ` Joe Perches
2021-06-09 5:15 ` Leizhen (ThunderTown) [this message]
2021-06-09 5:52 ` Joe Perches
2021-06-09 6:21 ` Leizhen (ThunderTown)
2021-06-09 6:35 ` Joe Perches
2021-06-09 10:30 ` Andy Shevchenko
2021-06-09 13:31 ` Leizhen (ThunderTown)
2021-06-09 21:44 ` Joe Perches
2021-06-10 9:10 ` Andy Shevchenko
2021-06-10 12:05 ` Joe Perches
2021-06-10 12:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26ee1009-259d-07a6-495f-87557be9ed8a@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).