From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Kees Cook <keescook@chromium.org>,
Jonathan Marek <jonathan@marek.ca>,
Rob Clark <robdclark@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the kspp-gustavo tree
Date: Mon, 12 Jul 2021 20:10:40 -0500 [thread overview]
Message-ID: <26f2ec3c-35ae-4361-62a4-ad0a84fc2399@embeddedor.com> (raw)
In-Reply-To: <20210713102230.728b4899@canb.auug.org.au>
Hi Stephen,
On 7/12/21 19:22, Stephen Rothwell wrote:
> Hi all,
>
> After merging the kspp-gustavo tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> /home/sfr/next/next/drivers/gpu/drm/msm/msm_gem.c: In function 'msm_gem_new_impl':
> /home/sfr/next/next/drivers/gpu/drm/msm/msm_gem.c:1170:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 1170 | if (priv->has_cached_coherent)
> | ^
> /home/sfr/next/next/drivers/gpu/drm/msm/msm_gem.c:1173:2: note: here
> 1173 | default:
> | ^~~~~~~
>
> Introduced by commit
>
> d12e339044a0 ("drm/msm: add MSM_BO_CACHED_COHERENT")
>
> Presumably exposed by commit
>
> 73ffc61f4a8b ("Makefile: Enable -Wimplicit-fallthrough for Clang")
>
> though I am not sure why since I am building with gcc. The first
> commit above introduces a new use of /* fallthrough */
We have previously adopted the new pseudo-keyword macro fallthrough; So,
we want to avoid having more /* fallthrough */ comments being introduced.
This is also being enforced by commit
73ffc61f4a8b ("Makefile: Enable -Wimplicit-fallthrough for Clang")
for both GCC and Clang.
So, the fix for this issue is merely to replace the /* fallthrough */ comment
with fallthrough;
Thanks
--
Gustavo
next prev parent reply other threads:[~2021-07-13 1:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 0:22 linux-next: build warning after merge of the kspp-gustavo tree Stephen Rothwell
2021-07-13 1:10 ` Gustavo A. R. Silva [this message]
2021-07-13 2:39 ` Gustavo A. R. Silva
-- strict thread matches above, loose matches on Subject: below --
2023-11-21 22:50 Stephen Rothwell
2023-11-21 23:19 ` Gustavo A. R. Silva
2023-11-21 22:47 Stephen Rothwell
2023-11-21 23:07 ` Gustavo A. R. Silva
2023-11-21 23:19 ` Stephen Rothwell
2023-11-21 23:23 ` Gustavo A. R. Silva
2021-09-29 23:53 Stephen Rothwell
2021-09-30 0:05 ` Gustavo A. R. Silva
2021-06-22 22:39 Stephen Rothwell
2021-06-22 22:46 ` Gustavo A. R. Silva
2021-06-22 23:01 ` Gustavo A. R. Silva
2021-06-23 3:03 ` Stephen Rothwell
2021-06-23 13:14 ` David Sterba
2021-06-23 18:39 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26f2ec3c-35ae-4361-62a4-ad0a84fc2399@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=jonathan@marek.ca \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).