From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gustavo@embeddedor.com
Subject: Re: [PATCH v2] video: fbdev: Mark expected switch fall-through
Date: Mon, 19 Aug 2019 16:04:06 +0200 [thread overview]
Message-ID: <270684a4-ce22-ebb8-73a8-c004674c8f5d@samsung.com> (raw)
In-Reply-To: <20190730152530.3055-1-anders.roxell@linaro.org>
On 7/30/19 5:25 PM, Anders Roxell wrote:
> Now that -Wimplicit-fallthrough is passed to GCC by default, the
> following warnings shows up:
>
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c: In function ‘sh_mobile_lcdc_channel_fb_init’:
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c:2086:22: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> info->fix.ypanstep = 2;
> ~~~~~~~~~~~~~~~~~~~^~~
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c:2087:2: note: here
> case V4L2_PIX_FMT_NV16:
> ^~~~
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c: In function ‘sh_mobile_lcdc_overlay_fb_init’:
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c:1596:22: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> info->fix.ypanstep = 2;
> ~~~~~~~~~~~~~~~~~~~^~~
> ../drivers/video/fbdev/sh_mobile_lcdcfb.c:1597:2: note: here
> case V4L2_PIX_FMT_NV16:
> ^~~~
>
> Rework to address a warnings due to the enablement of
> -Wimplicit-fallthrough.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Patch queued for v5.4, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2019-08-19 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190730152542epcas2p46c9b1c2e97c0b33df072e4fa1328f8d0@epcas2p4.samsung.com>
2019-07-30 15:25 ` [PATCH v2] video: fbdev: Mark expected switch fall-through Anders Roxell
2019-08-19 14:04 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=270684a4-ce22-ebb8-73a8-c004674c8f5d@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=anders.roxell@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@embeddedor.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).