From: Chen Yu <chenyu56@huawei.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: <liuyu712@hisilicon.com>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<john.stultz@linaro.org>, <suzhuangluan@hisilicon.com>,
<kongfei@hisilicon.com>, <wanghu17@hisilicon.com>,
<butao@hisilicon.com>, <chenyao11@huawei.com>,
<fangshengzhou@hisilicon.com>, <lipengcheng8@huawei.com>,
<songxiaowei@hisilicon.com>, <xuyiping@hisilicon.com>,
<xuyoujun4@huawei.com>, <yudongbin@hisilicon.com>,
<zangleigang@hisilicon.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Binghui Wang <wangbinghui@hisilicon.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960
Date: Mon, 4 Mar 2019 09:55:37 +0800 [thread overview]
Message-ID: <2708b188-d318-6758-a5fd-8573559b2e70@huawei.com> (raw)
In-Reply-To: <1551664069.2210.64.camel@mhfsdcap03>
Hi Chunfeng Yun,
On 2019/3/4 9:47, Chunfeng Yun wrote:
>> +
>> + hisi_hikey_usb->role_sw = usb_role_switch_get(dev);
>> + if (!hisi_hikey_usb->role_sw)
>> + return -EPROBE_DEFER;
> Here return EPROBE_DEFFER means the related device_connection is
> registered after this probe is called, right?
> if not, use IS_ERR_OR_NULL then return PTR_ERR is enough
Yes, the driver which register the usb_role_switch may finish probe after
this driver is probed for the first time.
>> + else if (IS_ERR(hisi_hikey_usb->role_sw))
>> + return PTR_ERR(hisi_hikey_usb->role_sw);
>> +
>> + ret = usb_role_switch_register_notifier(hisi_hikey_usb->role_sw,
>> + &hisi_hikey_usb->nb);
>> + if (ret) {
>> + usb_role_switch_put(hisi_hikey_usb->role_sw);
>> + return ret;
>> + }
>> +
>> + platform_set_drvdata(pdev, hisi_hikey_usb);
>> +
>> + return 0;
>> +}
>> +
>
>
> .
>
next prev parent reply other threads:[~2019-03-04 1:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 9:04 [PATCH v3 00/12] Add support for usb on Hikey960 Yu Chen
2019-03-02 9:04 ` [PATCH v3 01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2019-03-12 13:45 ` Rob Herring
2019-03-13 1:40 ` Chen Yu
2019-03-13 19:38 ` Rob Herring
2019-03-02 9:04 ` [PATCH v3 02/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2019-03-02 9:04 ` [PATCH v3 03/12] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Yu Chen
2019-03-02 9:04 ` [PATCH v3 04/12] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc Yu Chen
2019-03-04 23:53 ` kbuild test robot
2019-03-05 3:11 ` kbuild test robot
2019-03-02 9:04 ` [PATCH v3 05/12] usb: dwc3: Execute GCTL Core Soft Reset while switch mdoe " Yu Chen
2019-03-02 9:04 ` [PATCH v3 06/12] usb: dwc3: Increase timeout for CmdAct cleared by device controller Yu Chen
2019-03-02 15:47 ` Andy Shevchenko
2019-03-04 2:53 ` //Re: " Chen Yu
2019-03-02 9:05 ` [PATCH v3 07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2019-03-02 15:56 ` Andy Shevchenko
2019-03-04 2:37 ` Chen Yu
2019-03-02 9:05 ` [PATCH v3 08/12] usb: roles: Add usb role switch notifier Yu Chen
2019-03-02 9:05 ` [PATCH v3 09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2019-03-05 13:22 ` kbuild test robot
2019-03-02 9:05 ` [PATCH v3 10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2019-03-02 16:01 ` Andy Shevchenko
2019-03-04 2:35 ` Chen Yu
2019-03-04 6:55 ` Andy Shevchenko
2019-03-04 7:31 ` Chen Yu
2019-03-03 20:17 ` John Stultz
2019-03-04 1:27 ` Chen Yu
2019-03-04 1:47 ` Chunfeng Yun
2019-03-04 1:55 ` Chen Yu [this message]
2019-03-04 6:50 ` Andy Shevchenko
2019-03-04 6:58 ` Chunfeng Yun
2019-03-02 9:05 ` [PATCH v3 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2019-03-02 9:05 ` [PATCH v3 12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2019-03-04 12:15 ` [PATCH v3 00/12] " Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2708b188-d318-6758-a5fd-8573559b2e70@huawei.com \
--to=chenyu56@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=butao@hisilicon.com \
--cc=chenyao11@huawei.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fangshengzhou@hisilicon.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lipengcheng8@huawei.com \
--cc=liuyu712@hisilicon.com \
--cc=songxiaowei@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
--cc=wanghu17@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=xuyoujun4@huawei.com \
--cc=yudongbin@hisilicon.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).