From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C30CC2D0D2 for ; Fri, 20 Dec 2019 14:20:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 210C621655 for ; Fri, 20 Dec 2019 14:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576851630; bh=TjXYv2XWlJjKvxWvTY76Dq/6W8AtNpr91zwOv2hzrn8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=IBYHRXKHhwOpvGuj64WqDdsrPL9adHJ1XiUOkv9kQJDiK/3RG5luaosJci6jL2ALD GkRK8lHZbdsLbwYHFjvo0+YzBAzct/TNMJYn/NvsbR5AkfZAckOIHACOXdmDwPHjaz ZNGlqWPq0NjQDFzJwvTc5UcBSBqd2QLEpaYiD3pU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727431AbfLTOU3 (ORCPT ); Fri, 20 Dec 2019 09:20:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:59352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727347AbfLTOU2 (ORCPT ); Fri, 20 Dec 2019 09:20:28 -0500 Received: from [192.168.1.20] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3952F222C2; Fri, 20 Dec 2019 14:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576851628; bh=TjXYv2XWlJjKvxWvTY76Dq/6W8AtNpr91zwOv2hzrn8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=HVgwDkknfsEJq1Jwdr16JSdjPKuq8dR5FzcrGG4wEyc1QsRDmCk+byUT1vMoYusFi dlmBL3x3MJrmhNKgt3/O6+TGkRKdsdcxDuXXTzHYoXAqR3PUapJSHTtRrrCBo9/Mho JWKw1Q3iIyVqELQHUHEzJpiOf47vJvbaugS9fMAc= Subject: Re: [PATCH] serial: ucc_uart: remove redundant assignment to pointer bdp To: Colin King , Greg Kroah-Hartman , Jiri Slaby , linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191220001000.39859-1-colin.king@canonical.com> From: Timur Tabi Message-ID: <2714d205-245a-a4e1-8335-53405608a286@kernel.org> Date: Fri, 20 Dec 2019 08:20:24 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191220001000.39859-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/19/19 6:10 PM, Colin King wrote: > From: Colin Ian King > > The variable bdp is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Acked-by: Timur Tabi Looks like this bug has been there since day 1.