From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D096CC43461 for ; Tue, 6 Apr 2021 11:59:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5AEE613B8 for ; Tue, 6 Apr 2021 11:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343647AbhDFL7p (ORCPT ); Tue, 6 Apr 2021 07:59:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40980 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343634AbhDFL7l (ORCPT ); Tue, 6 Apr 2021 07:59:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617710373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2esLg1da59fOJXVhXC5LxhBQc2Y9aIayppe+mCmRoS0=; b=JcsZGyg/blrTAcR2iUSgx0xigkgz+ps7n+RI+07FRl2COQLTzdFF86kyLpKRQ6R5fF3LdW Eo34GkNr3qUBuORn6qwN8g6klDMajunoVMAPK8VpeiLGZJSd12CnSe4uqIuWipsSb7CV7e S5J+qdP3HbXmUgiBDSyieuCymShruho= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-466-trrCjbsPNv6uojW5o92q1A-1; Tue, 06 Apr 2021 07:59:32 -0400 X-MC-Unique: trrCjbsPNv6uojW5o92q1A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C5B6F81746A; Tue, 6 Apr 2021 11:59:28 +0000 (UTC) Received: from starship (unknown [10.35.206.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA0176B8E8; Tue, 6 Apr 2021 11:59:15 +0000 (UTC) Message-ID: <27193ea74081023b67ab9c98d7050b1e22655e79.camel@redhat.com> Subject: Re: [PATCH v2 0/9] KVM: my debug patch queue From: Maxim Levitsky To: Paolo Bonzini , kvm@vger.kernel.org Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Ingo Molnar , Andrew Morton , Thomas Gleixner , Sean Christopherson , Marc Zyngier , Catalin Marinas , open list , Julien Thierry , Stefano Garzarella , Borislav Petkov , Suzuki K Poulose , Jonathan Corbet , Jessica Yu , "H. Peter Anvin" , Jan Kiszka , Will Deacon , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , Vitaly Kuznetsov , Vasily Gorbik , Joerg Roedel , Claudio Imbrenda , Jim Mattson , Cornelia Huck , David Hildenbrand , Wanpeng Li , Janosch Frank , Christian Borntraeger , "open list:S390" , Heiko Carstens , Kieran Bingham , "open list:DOCUMENTATION" , "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , James Morse Date: Tue, 06 Apr 2021 14:59:14 +0300 In-Reply-To: References: <20210401135451.1004564-1-mlevitsk@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-04-02 at 19:38 +0200, Paolo Bonzini wrote: > On 01/04/21 15:54, Maxim Levitsky wrote: > > Hi! > > > > I would like to publish two debug features which were needed for other stuff > > I work on. > > > > One is the reworked lx-symbols script which now actually works on at least > > gdb 9.1 (gdb 9.2 was reported to fail to load the debug symbols from the kernel > > for some reason, not related to this patch) and upstream qemu. > > Queued patches 2-5 for now. 6 is okay but it needs a selftest. (e.g. > using KVM_VCPU_SET_EVENTS) and the correct name for the constant. Thanks! I will do this very soon. Best regards, Maxim Levitsky > > Paolo > > > The other feature is the ability to trap all guest exceptions (on SVM for now) > > and see them in kvmtrace prior to potential merge to double/triple fault. > > > > This can be very useful and I already had to manually patch KVM a few > > times for this. > > I will, once time permits, implement this feature on Intel as well. > > > > V2: > > > > * Some more refactoring and workarounds for lx-symbols script > > > > * added KVM_GUESTDBG_BLOCKEVENTS flag to enable 'block interrupts on > > single step' together with KVM_CAP_SET_GUEST_DEBUG2 capability > > to indicate which guest debug flags are supported. > > > > This is a replacement for unconditional block of interrupts on single > > step that was done in previous version of this patch set. > > Patches to qemu to use that feature will be sent soon. > > > > * Reworked the the 'intercept all exceptions for debug' feature according > > to the review feedback: > > > > - renamed the parameter that enables the feature and > > moved it to common kvm module. > > (only SVM part is currently implemented though) > > > > - disable the feature for SEV guests as was suggested during the review > > - made the vmexit table const again, as was suggested in the review as well. > > > > Best regards, > > Maxim Levitsky > > > > Maxim Levitsky (9): > > scripts/gdb: rework lx-symbols gdb script > > KVM: introduce KVM_CAP_SET_GUEST_DEBUG2 > > KVM: x86: implement KVM_CAP_SET_GUEST_DEBUG2 > > KVM: aarch64: implement KVM_CAP_SET_GUEST_DEBUG2 > > KVM: s390x: implement KVM_CAP_SET_GUEST_DEBUG2 > > KVM: x86: implement KVM_GUESTDBG_BLOCKEVENTS > > KVM: SVM: split svm_handle_invalid_exit > > KVM: x86: add force_intercept_exceptions_mask > > KVM: SVM: implement force_intercept_exceptions_mask > > > > Documentation/virt/kvm/api.rst | 4 + > > arch/arm64/include/asm/kvm_host.h | 4 + > > arch/arm64/kvm/arm.c | 2 + > > arch/arm64/kvm/guest.c | 5 - > > arch/s390/include/asm/kvm_host.h | 4 + > > arch/s390/kvm/kvm-s390.c | 3 + > > arch/x86/include/asm/kvm_host.h | 12 ++ > > arch/x86/include/uapi/asm/kvm.h | 1 + > > arch/x86/kvm/svm/svm.c | 87 +++++++++++-- > > arch/x86/kvm/svm/svm.h | 6 +- > > arch/x86/kvm/x86.c | 14 ++- > > arch/x86/kvm/x86.h | 2 + > > include/uapi/linux/kvm.h | 1 + > > kernel/module.c | 8 +- > > scripts/gdb/linux/symbols.py | 203 ++++++++++++++++++++---------- > > 15 files changed, 272 insertions(+), 84 deletions(-) > >