From: YueHaibing <yuehaibing@huawei.com>
To: <andriy.shevchenko@linux.intel.com>, <linus.walleij@linaro.org>,
<bgolaszewski@baylibre.com>, <rjw@rjwysocki.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] gpio: merrifield: Fix build err without CONFIG_ACPI
Date: Thu, 4 Apr 2019 22:04:04 +0800 [thread overview]
Message-ID: <271a33ae-b4fc-0528-cf59-5053dc46cce0@huawei.com> (raw)
In-Reply-To: <20190404103925.25652-1-yuehaibing@huawei.com>
+cc Rafael and linux-acpi
On 2019/4/4 18:39, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> When building CONFIG_ACPI is not set
> gcc warn this:
>
> drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name:
> drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device
> put_device(&adev->dev);
> ^
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpio/gpio-merrifield.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio-merrifield.c
> index 2383dc7..78ac32f 100644
> --- a/drivers/gpio/gpio-merrifield.c
> +++ b/drivers/gpio/gpio-merrifield.c
> @@ -379,17 +379,18 @@ static void mrfld_irq_init_hw(struct mrfld_gpio *priv)
>
> static const char *mrfld_gpio_get_pinctrl_dev_name(struct mrfld_gpio *priv)
> {
> - struct acpi_device *adev;
> const char *name;
> +#ifdef CONFIG_ACPI
> + struct acpi_device *adev;
>
> adev = acpi_dev_get_first_match_dev("INTC1002", NULL, -1);
> if (adev) {
> name = devm_kstrdup(priv->dev, acpi_dev_name(adev), GFP_KERNEL);
> put_device(&adev->dev);
> - } else {
> - name = "pinctrl-merrifield";
> }
> -
> +#else
> + name = "pinctrl-merrifield";
> +#endif
> return name;
> }
>
>
next prev parent reply other threads:[~2019-04-04 14:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 10:39 [PATCH] gpio: merrifield: Fix build err without CONFIG_ACPI Yue Haibing
2019-04-04 11:40 ` Mukesh Ojha
2019-04-04 11:44 ` Andy Shevchenko
2019-04-04 14:04 ` YueHaibing [this message]
2019-04-05 10:07 ` Andy Shevchenko
2019-04-05 12:11 ` YueHaibing
2019-04-05 14:21 ` [PATCH v2] " Yue Haibing
2019-04-05 14:50 ` Andy Shevchenko
2019-04-11 23:09 ` Rafael J. Wysocki
2019-04-12 13:13 ` Andy Shevchenko
2019-04-12 13:26 ` YueHaibing
2019-04-12 15:19 ` [PATCH v3] " Yue Haibing
2019-04-12 17:56 ` Andy Shevchenko
2019-04-23 9:17 ` Linus Walleij
2019-04-26 12:23 ` Andy Shevchenko
2019-04-29 8:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=271a33ae-b4fc-0528-cf59-5053dc46cce0@huawei.com \
--to=yuehaibing@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).