From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752847AbcGMKWW (ORCPT ); Wed, 13 Jul 2016 06:22:22 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32904 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbcGMKWD (ORCPT ); Wed, 13 Jul 2016 06:22:03 -0400 Subject: Re: [RFC PATCH 4/4] KVM: vmx: add support for emulating UMIP To: Yang Zhang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1468351223-3250-1-git-send-email-pbonzini@redhat.com> <1468351223-3250-5-git-send-email-pbonzini@redhat.com> <8f893604-1e80-2979-bc87-45a049238e58@gmail.com> <4e7bab78-61cf-271e-9fb9-685d217f8d0d@redhat.com> From: Paolo Bonzini Message-ID: <272876c1-2aea-7401-8221-d62e00e5fcee@redhat.com> Date: Wed, 13 Jul 2016 12:21:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/07/2016 12:02, Yang Zhang wrote: > On 2016/7/13 17:35, Paolo Bonzini wrote: >> >> >> On 13/07/2016 11:21, Yang Zhang wrote: >>>> >>>> +static int handle_desc(struct kvm_vcpu *vcpu) >>>> +{ >>>> + WARN_ON(!(vcpu->arch.cr4 & X86_CR4_UMIP)); >>> >>> I think WARN_ON is too heavy since a malicious guest may trigger it >>> always. >> >> I missed this---how so? Setting the bit is under "if ((cr4 & >> X86_CR4_UMIP) && !boot_cpu_has(X86_FEATURE_UMIP))". > > Sorry, I consider it under my previous suggestion(setting it > unconditionally). :( No problem, thanks for your interest! Paolo