From: Philipp Zabel <p.zabel@pengutronix.de>
To: Ezequiel Garcia <ezequiel@collabora.com>, linux-media@vger.kernel.org
Cc: kernel@collabora.com, Tomasz Figa <tfiga@chromium.org>,
linux-rockchip@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>, Jonas Karlman <jonas@kwiboo.se>,
Boris Brezillon <boris.brezillon@collabora.com>,
Chris Healy <cphealy@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] media: hantro: Support color conversion via post-processing
Date: Fri, 15 Nov 2019 17:10:59 +0100 [thread overview]
Message-ID: <272dedf2cc25053475e9536b446b434f4754f62c.camel@pengutronix.de> (raw)
In-Reply-To: <dc637b43a4ef4609f9200f3fc91ee76fef75f64a.camel@collabora.com>
Hi Ezequiel,
On Fri, 2019-11-15 at 12:44 -0300, Ezequiel Garcia wrote:
> Hello Philipp,
>
> Thanks for reviewing.
>
> On Thu, 2019-11-14 at 10:48 +0100, Philipp Zabel wrote:
[...]
> > Why isn't PP enabled in prepare_run? Does this mean the first frame is
> > not post-processed?
> >
>
> No, because hantro_finish_run is called (despite its name)
> before the decoding operation is actually triggered.
>
> I guess this hantro_finish_run name adds some confusion:
> prepare_run and finish_run should be something along
> start_prepare_run, end_prepare_run.
Ah, ok then. I was confused because I just came from looking at coda-vpu
code, where finish_run is a callback called after the device has
finished processing. Maybe I should rename that as well.
> And also, perhaps disabling the post-processor in prepare_run
> works just fine. I need to check that.
Ok.
[...]
> > > +#define HANTRO_PP_REG_WRITE_S(vpu, reg_name, val) \
> > > + do { \
> > > + if ((vpu)->variant->postproc_regs->(reg_name).base) \
> > > + hantro_reg_write((vpu), \
> > > + &(vpu)->variant->postproc_regs->(reg_name), \
> > > + (val)); \
> > > + } while (0)
> >
> > Why all these checks, are any of the register fields optional?
> >
>
> That was the plan. Perhaps now it makes less sense,
> but maybe it's safer this way, if it's extended?
>
> OTOH, we might want to make sure the driver fails (or warns).
I think that would be better than silently ignoring them.
Although I don't quite see the point in repeatedly checking the presence
of mandatory register fields at runtime.
regards
Philipp
next prev parent reply other threads:[~2019-11-15 16:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 17:56 [PATCH v3 0/3] Enable Hantro G1 post-processor Ezequiel Garcia
2019-11-13 17:56 ` [PATCH v3 1/3] media: hantro: Cleanup format negotiation helpers Ezequiel Garcia
2019-11-14 9:26 ` Philipp Zabel
2019-11-14 9:32 ` Boris Brezillon
2019-11-13 17:56 ` [PATCH v3 2/3] media: hantro: Support color conversion via post-processing Ezequiel Garcia
2019-11-14 9:46 ` Boris Brezillon
2019-11-14 9:48 ` Philipp Zabel
2019-11-15 15:44 ` Ezequiel Garcia
2019-11-15 16:10 ` Philipp Zabel [this message]
2019-12-05 14:33 ` Ezequiel Garcia
2019-12-05 14:46 ` Philipp Zabel
2019-12-05 16:02 ` Ezequiel Garcia
2019-11-13 17:56 ` [PATCH v3 3/3] media: vidioc-enum-fmt.rst: clarify format preference Ezequiel Garcia
2019-11-14 9:32 ` Boris Brezillon
2020-02-09 19:52 ` [PATCH v3 0/3] Enable Hantro G1 post-processor Nicolas Dufresne
2020-02-10 2:45 ` Tomasz Figa
2020-02-11 4:16 ` Nicolas Dufresne
2020-02-11 16:22 ` Nicolas Dufresne
2020-02-12 7:06 ` Tomasz Figa
2020-02-19 21:06 ` Nicolas Dufresne
2020-03-09 11:11 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=272dedf2cc25053475e9536b446b434f4754f62c.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=boris.brezillon@collabora.com \
--cc=cphealy@gmail.com \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).